For #21339: update styles for homescreen to match new specs #21342

eliserichards · 2021-09-16T20:52:31Z

For #21339

Updates the "show all" buttons on the home screen. Adds correct spacing in between jump back in cards.

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

eliserichards · 2021-09-16T23:58:28Z

Failing UI tests:

verifyExpandedCollectionItemsTest: works locally ✅
createFirstCollectionTest: works locally ✅
verifyAddTabButtonOfCollectionMenu: works locally ✅
renameCollectionTest: works locally ✅

eliserichards · 2021-09-20T19:24:35Z

@Mergifyio rebase

mergify · 2021-09-20T19:25:15Z

Command rebase: success

Branch has been successfully rebased

mergify · 2021-09-20T19:43:09Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

eliserichards · 2021-09-20T20:55:13Z

Same UI tests failing again, and all run fine locally:

verifyExpandedCollectionItemsTest: logs
createFirstCollectionTest: logs
verifyAddTabButtonOfCollectionMenu: logs
renameCollectionTest: logs

Adding ignores and filing a bug for help: #21397

app/src/main/java/org/mozilla/fenix/home/recenttabs/view/RecentTabs.kt

app/src/main/res/layout/recent_bookmarks_header.xml

gabrielluong

Will pull down and test it out after lunch

app/src/main/res/layout/history_metadata_header.xml

gabrielluong · 2021-09-22T20:06:14Z

app/src/main/res/values-night/colors.xml

@@ -93,7 +93,7 @@
    <color name="collection_icon_color_yellow">@color/collection_icon_color_yellow_dark_theme</color>

    <!-- Home screen -->
-    <color name="home_show_all_button_text">@color/photonLightGrey50</color>
+    <color name="home_show_all_button_text">#AB71FF</color>


This should be equivalent to photonViolet40. You can usually see the color name in figma if you select the CSS.

Oui, the color variable for photonViolet40 is equivalent to #AB71FF is what I am trying to say
https://searchfox.org/mozilla-mobile/source/android-components/components/ui/colors/src/main/res/values/photon_colors.xml#180

We don't have that in our .values folder on Fenix. What's the correct way to add a new photon color here?

Should simply be @color/photonViolet40

that's in android components. Try it locally. We build our @color/photonXXX values based on https://github.com/mozilla-mobile/android-components/blob/releases/93.0/components/ui/colors/src/main/res/values/photon_colors.xml and you can see that violet40 isn't there

I'm not adding that in this PR. I'm gonna expose it on AC then update here.

It's there in AC. https://github.com/mozilla-mobile/android-components/blob/main/components/ui/colors/src/main/res/values/photon_colors.xml#L180. We aren't pinned to the 93 release in main which is what you linked.

Trust, I suspect your local dev is not rebased or might need a sync.

We can also omit the change and I can add it in a separate PR if we are still having issues, but the color definitely exists in AC already.

app/src/main/res/values/strings.xml

mergify · 2021-09-22T21:35:54Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

app/src/main/res/layout/recent_tabs_header.xml

eliserichards · 2021-09-23T19:34:10Z

@gabrielluong I cleaned everything up a bunch and removed all of the unnecessary white space around bookmarks and top sites, as well as making sure collections and "no collections" were matching. lmk what you think :)

eliserichards · 2021-09-23T19:51:01Z

Making some changes to "customize" button based on Nicole's feedback...

eliserichards · 2021-09-23T20:06:16Z

Modified the collections header so that it takes into account the top margins above each of the collections and still matches the spacing of the other headers. Spaced out the "customize" button so that it matches the space in between each section, even when collections aren't shown:

mergify · 2021-09-24T07:47:03Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

cadeyrn · 2021-09-24T15:47:49Z

@eliserichards While you are at it, could you also fix the overlap of the card headers and the "show all" link which happens in languages with longer translations? I checked out your current work on this issue and while it's better due to the smaller font it's still an issue. I attached a screenshot of the "recently saved" section ("Kürzlich als Lesezeichen gesetzt" in German) so that you can see the issue (left: main branch, right: your branch for this issue).

eliserichards · 2021-09-27T16:18:07Z

@cadeyrn thank you so much for pointing that out! I'm going to land this and tackle that issue in a new PR :D

eliserichards · 2021-09-27T20:58:57Z

Flaky test:

TitleHeaderBindingTest. WHEN grouped tabs are added to the list THEN return false

eliserichards · 2021-09-27T20:59:07Z

@Mergifyio rebase

mergify · 2021-09-27T20:59:40Z

Command rebase: success

Branch already up to date

mergify · 2021-09-27T21:12:03Z

This pull request has conflicts when rebasing. Could you fix it @eliserichards? 🙏

…ns and jump back in spacing For mozilla-mobile#21339: Add ignores for intermittent ui tests

eliserichards added the needs:review PRs that need to be reviewed label Sep 16, 2021

eliserichards requested review from a team as code owners September 16, 2021 20:52

eliserichards force-pushed the 21339-show-all-btn-style branch from d089589 to 0b4ff45 Compare September 16, 2021 20:53

eliserichards linked an issue Sep 16, 2021 that may be closed by this pull request

Update "show all" buttons on home #21339

Closed

MozillaNoah approved these changes Sep 16, 2021

View reviewed changes

eliserichards force-pushed the 21339-show-all-btn-style branch from 0b4ff45 to a85c54e Compare September 16, 2021 21:05

eliserichards force-pushed the 21339-show-all-btn-style branch from a85c54e to 2d4a8e4 Compare September 17, 2021 00:00

eliserichards added pr:do-not-land pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land and removed needs:review PRs that need to be reviewed labels Sep 20, 2021

eliserichards force-pushed the 21339-show-all-btn-style branch from 2d4a8e4 to 91024fd Compare September 20, 2021 19:25

eliserichards mentioned this pull request Sep 20, 2021

Intermittent UI test failures - CollectionsTest and SmokeTest #21397

Closed

eliserichards force-pushed the 21339-show-all-btn-style branch from 91024fd to 60c4ccd Compare September 20, 2021 21:29

gabrielluong suggested changes Sep 22, 2021

View reviewed changes

app/src/main/java/org/mozilla/fenix/home/recenttabs/view/RecentTabs.kt Outdated Show resolved Hide resolved

gabrielluong reviewed Sep 22, 2021

View reviewed changes

app/src/main/res/layout/recent_bookmarks_header.xml Outdated Show resolved Hide resolved

eliserichards force-pushed the 21339-show-all-btn-style branch from 60c4ccd to fcffbbd Compare September 22, 2021 20:03

eliserichards requested a review from gabrielluong September 22, 2021 20:04

gabrielluong reviewed Sep 22, 2021

View reviewed changes

eliserichards force-pushed the 21339-show-all-btn-style branch from fcffbbd to e694898 Compare September 22, 2021 20:21

gabrielluong suggested changes Sep 22, 2021

View reviewed changes

app/src/main/res/layout/recent_tabs_header.xml Show resolved Hide resolved

eliserichards force-pushed the 21339-show-all-btn-style branch from e694898 to 208949b Compare September 23, 2021 19:32

eliserichards force-pushed the 21339-show-all-btn-style branch from 208949b to 7218dd7 Compare September 23, 2021 19:48

eliserichards force-pushed the 21339-show-all-btn-style branch from 7218dd7 to 4cbabb2 Compare September 23, 2021 20:04

eliserichards requested a review from gabrielluong September 23, 2021 20:08

gabrielluong approved these changes Sep 23, 2021

View reviewed changes

eliserichards mentioned this pull request Sep 27, 2021

Word wrap for homescreen section titles #21522

Closed

eliserichards force-pushed the 21339-show-all-btn-style branch from 4cbabb2 to 52f429a Compare September 27, 2021 20:08

eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:do-not-land pr:waiting-for-authors PR that has been approved and awaiting any changes before they can land labels Sep 27, 2021

eliserichards closed this Sep 27, 2021

eliserichards reopened this Sep 27, 2021

eliserichards mentioned this pull request Sep 27, 2021

For #21313: Renewing performance awesomebar metrics #21315

Merged

3 tasks

For mozilla-mobile#21339: update styles for homescreen show all butto…

e1dfb6b

…ns and jump back in spacing For mozilla-mobile#21339: Add ignores for intermittent ui tests

eliserichards force-pushed the 21339-show-all-btn-style branch from 52f429a to e1dfb6b Compare September 28, 2021 20:04

eliserichards added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed pr:needs-landing PRs that are ready to land [Will be merged by Mergify] labels Sep 28, 2021

Merge branch 'main' into 21339-show-all-btn-style

7679e4f

eliserichards merged commit 777f2d1 into mozilla-mobile:main Sep 28, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

For #21339: update styles for homescreen to match new specs #21342

For #21339: update styles for homescreen to match new specs #21342

eliserichards commented Sep 16, 2021

eliserichards commented Sep 16, 2021 •

edited

eliserichards commented Sep 20, 2021

mergify bot commented Sep 20, 2021

mergify bot commented Sep 20, 2021

eliserichards commented Sep 20, 2021 •

edited

gabrielluong left a comment

gabrielluong Sep 22, 2021

eliserichards Sep 22, 2021

gabrielluong Sep 22, 2021 •

edited

eliserichards Sep 22, 2021

gabrielluong Sep 22, 2021 •

edited

eliserichards Sep 23, 2021

eliserichards Sep 23, 2021

eliserichards Sep 23, 2021

gabrielluong Sep 23, 2021 •

edited

gabrielluong Sep 23, 2021

mergify bot commented Sep 22, 2021

eliserichards commented Sep 23, 2021 •

edited

eliserichards commented Sep 23, 2021

eliserichards commented Sep 23, 2021 •

edited

mergify bot commented Sep 24, 2021

cadeyrn commented Sep 24, 2021 •

edited

eliserichards commented Sep 27, 2021

eliserichards commented Sep 27, 2021

eliserichards commented Sep 27, 2021

mergify bot commented Sep 27, 2021

mergify bot commented Sep 27, 2021

For #21339: update styles for homescreen to match new specs #21342

For #21339: update styles for homescreen to match new specs #21342

Conversation

eliserichards commented Sep 16, 2021

Pull Request checklist

To download an APK when reviewing a PR:

eliserichards commented Sep 16, 2021 • edited

eliserichards commented Sep 20, 2021

mergify bot commented Sep 20, 2021

mergify bot commented Sep 20, 2021

eliserichards commented Sep 20, 2021 • edited

gabrielluong left a comment

Choose a reason for hiding this comment

gabrielluong Sep 22, 2021

Choose a reason for hiding this comment

eliserichards Sep 22, 2021

Choose a reason for hiding this comment

gabrielluong Sep 22, 2021 • edited

Choose a reason for hiding this comment

eliserichards Sep 22, 2021

Choose a reason for hiding this comment

gabrielluong Sep 22, 2021 • edited

Choose a reason for hiding this comment

eliserichards Sep 23, 2021

Choose a reason for hiding this comment

eliserichards Sep 23, 2021

Choose a reason for hiding this comment

eliserichards Sep 23, 2021

Choose a reason for hiding this comment

gabrielluong Sep 23, 2021 • edited

Choose a reason for hiding this comment

gabrielluong Sep 23, 2021

Choose a reason for hiding this comment

mergify bot commented Sep 22, 2021

eliserichards commented Sep 23, 2021 • edited

eliserichards commented Sep 23, 2021

eliserichards commented Sep 23, 2021 • edited

mergify bot commented Sep 24, 2021

cadeyrn commented Sep 24, 2021 • edited

eliserichards commented Sep 27, 2021

eliserichards commented Sep 27, 2021

eliserichards commented Sep 27, 2021

mergify bot commented Sep 27, 2021

mergify bot commented Sep 27, 2021

eliserichards commented Sep 16, 2021 •

edited

eliserichards commented Sep 20, 2021 •

edited

gabrielluong Sep 22, 2021 •

edited

gabrielluong Sep 22, 2021 •

edited

gabrielluong Sep 23, 2021 •

edited

eliserichards commented Sep 23, 2021 •

edited

eliserichards commented Sep 23, 2021 •

edited

cadeyrn commented Sep 24, 2021 •

edited