Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #21896 - Add SwipeToDismiss gesture to Tabs Tray #26166

Closed
wants to merge 3 commits into from

Conversation

Alexandru2909
Copy link
Contributor

@Alexandru2909 Alexandru2909 commented Jul 25, 2022

Added swipe to delete gesture support for TabListItem and TabGridItem.

TabLisItem swipe to delete:

listWorking.mp4

We need to migrate the RecyclerView in order to obtain the same functionality as the one currently implemented in TabsTouchHelper for TabGridItem, see the recordings below:

  • Behavior in LazyGrid
swipeInLazyGrid.mp4
  • Behavior in current RV
swipeInCurrentRV.mp4

This PR is based on #25891.
We should wait for #21899 to be merged before landing this.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #25891
Fixes #21896

@Alexandru2909 Alexandru2909 added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2022

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 24, 2022

This pull request has conflicts when rebasing. Could you fix it @Alexandru2909? 🙏

@gabrielluong gabrielluong added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on 🙅 waiting Issues that are blocked or has dependencies that are not ready
Projects
None yet
2 participants