Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Move Tabs Tray to compose: Individual tab viewholders: GridViewHolder #25891

Closed
Tracked by #21318
Amejia481 opened this issue Jul 5, 2022 · 1 comment · Fixed by #25996, nathanmkaya/fenix#108 or fork-house/fenix#12
Closed
Tracked by #21318

Move Tabs Tray to compose: Individual tab viewholders: GridViewHolder #25891

Amejia481 opened this issue Jul 5, 2022 · 1 comment · Fixed by #25996, nathanmkaya/fenix#108 or fork-house/fenix#12
Assignees
@Alexandru2909
Labels
compose Tickets involving Composable changes
Milestone
105

Comments

@Amejia481
Copy link
Contributor

Amejia481 commented Jul 5, 2022 •
edited by data-sync-user

Related ticket #21894

┆Issue is synchronized with this Jira Task
@github-actions github-actions bot added the needs:triage Issue needs triage label Jul 5, 2022
@Alexandru2909 Alexandru2909 self-assigned this Jul 6, 2022
@Alexandru2909 Alexandru2909 added compose Tickets involving Composable changes and removed needs:triage Issue needs triage labels Jul 6, 2022
@MozillaNoah MozillaNoah mentioned this issue Jul 6, 2022
Closed
13 tasks
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 12, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
8ec56c1
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 12, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
807ba93
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 12, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
6e9d53c
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 15, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
b0fcf7f
@github-actions github-actions bot mentioned this issue Jul 15, 2022
Merged
3 tasks
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 15, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
ba9ade2
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 15, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
be87946
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 15, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
fdc4686
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 15, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
a32f240
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 18, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
4b6bdb2
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 18, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
1128ac7
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 19, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
4e04e50
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 20, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
0337a38
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 20, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
f4db9b1
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 20, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
33fb327
JohanLorenzo pushed a commit to Alexandru2909/fenix that referenced this issue Jul 20, 2022
@JohanLorenzo
For mozilla-mobile#25891 - Move GridViewHolder to compose
494caa3
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 22, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
0c42dda
@Alexandru2909 Alexandru2909 mentioned this issue Jul 25, 2022
Closed
4 tasks
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 25, 2022
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 25, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
dba9b75
Alexandru2909 pushed a commit to Alexandru2909/fenix that referenced this issue Jul 26, 2022
For mozilla-mobile#25891 - Move GridViewHolder to compose
293974f
@mergify mergify bot closed this as completed in #25996 Jul 26, 2022
mergify bot pushed a commit that referenced this issue Jul 26, 2022
@mergify
For #25891 - Move GridViewHolder to compose
335159c
@github-actions github-actions bot reopened this Jul 26, 2022
@github-actions github-actions bot removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Jul 26, 2022
@github-actions github-actions bot added the eng:qa:needed QA Needed label Jul 26, 2022
@github-actions github-actions bot added this to the 105 milestone Jul 26, 2022
@github-actions github-actions bot mentioned this issue Jul 26, 2022
Merged
@Alexandru2909
Copy link
Contributor

Closing this as it is not ready to be tested by QA for the following reasons:

  • Composed tabs tray is only available in debug builds.
  • We don't have support for tabs re-ordering in compose yet.

@github-actions github-actions bot mentioned this issue Aug 30, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Alexandru2909 Alexandru2909

Labels
compose Tickets involving Composable changes
Projects
None yet
Milestone
105
3 participants
@Amejia481 @Alexandru2909 @SoftVision-LorandJanos