Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Revert "Closes #24307: add synced history empty fragment, feature flag and history screen showing only local files #26530

Conversation

mavduevskiy
Copy link
Contributor

Due to difficult UX edge cases, we decided to pause the development of synced history feature until a solution we are sure about is not designed.

Reverts #24374

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Used by GitHub Actions.

Copy link
Contributor

@rocketsroger rocketsroger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one thing I want to note here is that we are reverting more than the original change but this is because we know we're reverting one more change after this.

@mavduevskiy mavduevskiy added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 18, 2022
@mavduevskiy mavduevskiy reopened this Aug 18, 2022
@rvandermeulen rvandermeulen reopened this Aug 18, 2022
@mavduevskiy mavduevskiy reopened this Aug 18, 2022
@mavduevskiy mavduevskiy reopened this Aug 18, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2022

This pull request has conflicts when rebasing. Could you fix it @mavduevskiy? 🙏

…t, feature flag and history screen showing only local files
@mavduevskiy mavduevskiy force-pushed the revert-synced-history-fragment-and-flag branch from 2ba9dfd to e0cffdb Compare August 18, 2022 20:54
@rvandermeulen rvandermeulen reopened this Aug 18, 2022
@mergify mergify bot merged commit c90debf into mozilla-mobile:main Aug 18, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this pull request Aug 19, 2022
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 19, 2022
mavduevskiy pushed a commit to mavduevskiy/fenix that referenced this pull request Aug 19, 2022
mergify bot pushed a commit that referenced this pull request Aug 19, 2022
@gabrielluong gabrielluong removed the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants