Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #26093: Use ic_menu instead of ic_close #26705

Closed
wants to merge 2 commits into from

Conversation

czlucius
Copy link
Contributor

@czlucius czlucius commented Aug 30, 2022

This PR is for #26093

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.
    Screenshots of the fix:
    photo_2022-08-30_12-12-57
    photo_2022-08-30_12-12-56

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #26093

An override for History already exists in `HistoryListItemViewHolder`, so no global override for this icon is needed.
@czlucius czlucius requested review from a team as code owners August 30, 2022 04:13
@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

Copy link
Contributor

@Mugurell Mugurell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you!
Will help land.

@Mugurell Mugurell added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 30, 2022
@Mugurell Mugurell closed this Aug 30, 2022
@Mugurell Mugurell reopened this Aug 30, 2022
@Mugurell Mugurell removed the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Aug 30, 2022
@rvandermeulen
Copy link
Contributor

Landed in #26707.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: 3 dot menu icons in Bookmarks are displayed as close ("X") icons
3 participants