For #27468 - Backplate homepage MessageCard

[MozillaNoah]

Light	Dark

In essence, this section is styled the same as the recent synced tab (Jump back in)

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

• QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

1. Click on Checks at the top of the PR page.
2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
3. Click on the build-debug task.
4. Click on View task in Taskcluster in the new DETAILS section.
5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27468

[gabrielluong]

Suggested change

	val defaultMessageCardColors = MessageCardColors.buildMessageCardColors()
	var buttonColor = defaultMessageCardColors.buttonColor
	var buttonTextColor = defaultMessageCardColors.buttonTextColor
	var (buttonColor, buttonTextColor) = MessageCardColors.buildMessageCardColors()

Wondering if we could use destructuring declaration here to save us a few lines https://kotlinlang.org/docs/destructuring-declarations.html

[MatthewTighe]

If we wanted to go fully immutable you may be able to do something like this, even:

val (buttonColor, buttonTextColor) = if (isWallpaperNotDefault) {
    FirefoxTheme.colors.layer1 to if (!isSystemInDarkTheme()) { FirefoxTheme.colors.textActionSecondary } else defaultMessageCardColors.buttonTextColor
} else {
   MessageCardColors.buildMessageCardColors()
}

Definitely a little code golfy though 😅

[MozillaNoah]

I had no idea about the destructuring! that's really cool! I had to just insert some underscores though, as the destructuring is tied to the ordering of the parameters.

var (_, _, _, _, buttonColor, buttonTextColor) = MessageCardColors.buildMessageCardColors()

[Kate-Galetski]

Looks Correct!