Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #27746 - Move Top Sites text outside of backplating #27711

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

MozillaNoah
Copy link
Contributor

@MozillaNoah MozillaNoah commented Nov 4, 2022

https://www.figma.com/file/RlHwo5VqpEPAgYF1W4aisr/Mobile-Sponsored-Shortcuts?node-id=2%3A4

Light Dark
No wallpaper selected

Changelog

  • Initial commit
    • The text has been moved outside of the backplating
    • The title/sponsor name is colored to the wallpaper text color
    • The pin is colored to the wallpaper text color
    • The “Sponsored” subtitle is colored to the wallpaper text color with an alpha of 0.66
  • Removed transparency from "Sponsored"
  • Rebased with main so the builds include the latest backplating changes.
  • Split the commits: one for the layout revert, and one for any design changes
  • Added ignores for UI tests that fail as a result of the reversion.
  • Added a 4dp margin to the favicon card so the shadow fully renders. (screenshots updated)
  • Created an issue and added issue number to commits and PR.
  • PR feedback review
    • Re organized some of the text color setting.
    • Added back in focusable to root View

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #27746

@MozillaNoah MozillaNoah changed the title temp commit For #????? - Move top sites text outside of backplating Nov 4, 2022
@MozillaNoah MozillaNoah changed the title For #????? - Move top sites text outside of backplating For #????? - Move Top Sites text outside of backplating Nov 4, 2022
@MozillaNoah MozillaNoah closed this Nov 4, 2022
@MozillaNoah MozillaNoah reopened this Nov 4, 2022
@gabrielluong gabrielluong self-assigned this Nov 4, 2022
@gabrielluong gabrielluong self-requested a review November 4, 2022 19:34
@MozillaNoah MozillaNoah force-pushed the move-top-sites-text branch 2 times, most recently from 7f1b878 to 8eebec5 Compare November 7, 2022 19:37
@MozillaNoah MozillaNoah changed the title For #????? - Move Top Sites text outside of backplating For #27746 - Move Top Sites text outside of backplating Nov 7, 2022
@MozillaNoah MozillaNoah marked this pull request as ready for review November 7, 2022 19:45
@MozillaNoah MozillaNoah requested review from a team as code owners November 7, 2022 19:45
@MozillaNoah MozillaNoah closed this Nov 7, 2022
@MozillaNoah MozillaNoah reopened this Nov 7, 2022
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Nov 7, 2022
@MozillaNoah MozillaNoah added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Nov 7, 2022
@mergify mergify bot merged commit c59b084 into mozilla-mobile:main Nov 7, 2022
@onemahon
Copy link

onemahon commented Nov 9, 2022

@Mergifyio backport releases_v107.0.0

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2022

backport releases_v107.0.0

✅ Backports have been created

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the text of Top Sites outside of the backplating
3 participants