Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #25810 - Unified search should give hint to user that there are more menu items available by scrolling #27895

Merged
merged 3 commits into from
Jan 9, 2023

Conversation

t-p-white
Copy link
Contributor

@t-p-white t-p-white commented Nov 18, 2022

Bulk of changes are in AC: See mozilla-mobile/firefox-android#181 for AC details.

The unified search 'search popup menu' should give hint to the user that there are more menu items available by scrolling. This is indicated by displaying a half menu item if the available height will not fit the full list of items.

Existing behaviour :

Original.implementation.mov

New behaviour LTR:

Screen.Recording.2023-01-03.at.15.46.15.mov

New behaviour RTL:

Screen.Recording.2023-01-03.at.15.49.03.mov

UI states:

  • Does menu fit or does menu have to scroll
  • Search bar Top/Bottom
    • Portrait keyboard open
    • Portrait keyboard closed
    • Landscape keyboard open
    • Landscape keyboard closed

Note: This issue is covering the direction and popup height only, another issue is in progress for positioning #27998.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #25810

@Mugurell
Copy link
Contributor

Talked with @Verdi about what's still needed for the unified search feature and understood that we won't need to have the selector be shown above the keyboard.
Pinging him for visibility.

@Verdi
Copy link

Verdi commented Nov 23, 2022

Yes - after trying the menu positioned over the keyboard, I think it's better to show the whole thing when we can and it's ok to cover the keyboard in this case.

@t-p-white
Copy link
Contributor Author

Thanks @Mugurell

Yes - after trying the menu positioned over the keyboard, I think it's better to show the whole thing when we can and it's ok to cover the keyboard in this case.

@Verdi ok thanks for the feedback, what is the preference on the orientation? Would a 'down' orientation perhaps more thumb friendly?

@t-p-white t-p-white added the needs:UX-feedback Needs UX Feedback label Nov 25, 2022
@mavduevskiy
Copy link
Contributor

Thanks @Mugurell

Yes - after trying the menu positioned over the keyboard, I think it's better to show the whole thing when we can and it's ok to cover the keyboard in this case.

@Verdi ok thanks for the feedback, what is the preference on the orientation? Would a 'down' orientation perhaps more thumb friendly?

@Verdi
I would also follow up with the question if we want to give the hint about more items if there is just not enough space for the list? For example, the landscape mode will not allow to show the whole list even with the hidden keyboard.

…at there are more menu items available by scrolling
@rocketsroger rocketsroger added pr:approved PR that has been approved and removed needs:review PRs that need to be reviewed labels Jan 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Jan 9, 2023

This pull request has conflicts when rebasing. Could you fix it @t-p-white? 🙏

@t-p-white t-p-white added the pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify] label Jan 9, 2023
@mergify mergify bot merged commit b8a4dfe into mozilla-mobile:main Jan 9, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this pull request Jan 12, 2023
…int to user that there are more menu items available by scrolling (mozilla-mobile/fenix#27895)

* For mozilla-mobile/fenix#25810 - Unified search should give hint to user that there are more menu items available by scrolling

* For mozilla-mobile/fenix#25810: Updated AC version

Co-authored-by: t-p-white <t-p-white>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing-squashed PRs that are ready to land (squashed) [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unified search engine menu popup should give hints to the user that more selection is available by scrolling
5 participants