Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug]: Allows users to choose as defaults only general or custom search engines #28111

Closed
DreVla opened this issue Dec 7, 2022 · 3 comments · Fixed by #28112
Closed

[Bug]: Allows users to choose as defaults only general or custom search engines #28111

DreVla opened this issue Dec 7, 2022 · 3 comments · Fixed by #28112
Assignees
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Milestone

Comments

@DreVla
Copy link
Contributor

DreVla commented Dec 7, 2022

Steps to reproduce

  1. Go to Settings
  2. Go to Search
  3. Inspect default search engine options

Expected behaviour

Only general or custom search engines should be available to be set as default search engine.
If users have a topic specific search engine set as default then the default should be automatically migrated to the first available general search engine. Only if no other general search engines are available then the user will remain with the current topic-specific engine set as default.

Actual behaviour

Any search engine can be selected as default search engine, including topic specific engines (amazon, ebay, etc...).

Screenshot 2022-12-07 at 16 22 06

Device name

No response

Android version

Android 10

Firefox release type

Firefox Nightly

Firefox version

109.0a1

Device logs

No response

Additional information

Because topic specific search engines - like amazon / ebay / wikipedia will only show results from those specific websites - a restricted scope they are not suited for general searches - all around the web.

We need to limit the user’s ability to set such engines as defaults.
Since these search engines come bundled with the app we have control over them and can manually split each list of search engines for a specific locale to general or topic specific (naming not necessarily following this scheme).

This will not apply to user added search engines. All custom search engines will be treated as general search engines.

┆Issue is synchronized with this Jira Task

@DreVla DreVla added 🐞 bug Crashes, Something isn't working, .. needs:triage Issue needs triage labels Dec 7, 2022
@DreVla DreVla self-assigned this Dec 7, 2022
DreVla added a commit to DreVla/fenix that referenced this issue Dec 7, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@github-actions github-actions bot added the eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged label Dec 7, 2022
@DreVla DreVla removed the needs:triage Issue needs triage label Dec 7, 2022
DreVla added a commit to DreVla/fenix that referenced this issue Dec 8, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 9, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 9, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 15, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 15, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 21, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 22, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 22, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@cadeyrn
Copy link
Contributor

cadeyrn commented Dec 23, 2022

We need to limit the user’s ability to set such engines as defaults.

@DreVla Why do you see this need? I would argue that an user who sets a topic specific search engine as default search engine, for example Amazon, is well aware that they will only find products on Amazon. And if they use the browser very frequently for the search for products (or articles on Wikipedia or whatever), what is wrong with allowing the user to set that search engine as the default search engine? I don't get the point of this change. 🤔

Also, Firefox for desktop allows this. When the ability to only show pinned top sites (without sites from the history) on the home screen was removed, it was argued with consistency with Firefox for desktop. Now you remove something that will give the user the opposite of the desktop behaviour.

DreVla added a commit to DreVla/fenix that referenced this issue Dec 23, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@Mugurell
Copy link
Contributor

Mugurell commented Dec 23, 2022

@cadeyrn This limitation will be part of the new unified search UX which will allow users to easily switch from the toolbar to another search engine - like Amazon or to another application source - like open tabs. You can see that UI here - #27895.
There will be important differences between the UX for a general search engine like DuckDuckGo and the UX for a search engine like eBay.
Also the UX reasoning is that quick searches should show results from all over the internet - hence only search engines like DuckDuckGo, Google, Bing, can be set as default.
Will double check with UX and product.

DreVla added a commit to DreVla/fenix that referenced this issue Dec 23, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Dec 23, 2022
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Jan 16, 2023
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Jan 18, 2023
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
DreVla added a commit to DreVla/fenix that referenced this issue Jan 18, 2023
…om default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@mergify mergify bot closed this as completed in #28112 Jan 20, 2023
mergify bot pushed a commit that referenced this issue Jan 20, 2023
Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@github-actions github-actions bot added this to the 111 milestone Jan 20, 2023
@github-actions github-actions bot reopened this Jan 20, 2023
@github-actions github-actions bot added eng:qa:needed QA Needed and removed eng:reopen-for-qa Reopens and tags the issue for QA needed when the issue is merged labels Jan 20, 2023
JohanLorenzo pushed a commit to mozilla-releng/staging-firefox-android that referenced this issue Jan 25, 2023
…rch engines from default list

Since topic specific search engines, like amazon, ebay, etc...
will only show results from those specific websites, they will be filtered
out of the default search engines list.
@SoftVision-LorandJanos
Copy link

Verified as fixed on the latest Nightly 111.0a1 (2023-01-27) build.
Only general and custom search engines can be chosen as default.
Device used: Oppo Find X5 (Android 12).
Closing the ticket as verified.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🐞 bug Crashes, Something isn't working, .. eng:qa:verified QA Verified
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants