For #28428: update growth data with new events #28429

MatthewTighe · 2023-01-06T00:28:23Z

Decided to address all the new requirements in a single issue instead of splitting them, in order to make the uplift a bit more manageable. In retrospect, probably would've been good to do separate commits but I wasn't sure how well mergify would handle that so thanks in advance!

Note: we will need to wait to land this until it can be updated with actual event tokens for the new growth data but as of posting they had not been generated yet. Thought it would be more beneficial to get reviews early

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

Click on Checks at the top of the PR page.
Click on the firefoxci-taskcluster group on the left to expand all tasks.
Click on the build-debug task.
Click on View task in Taskcluster in the new DETAILS section.
The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #28428

app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt

t-p-white · 2023-01-06T10:50:44Z

app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt

         */
-        object FirstUriLoadForDay : GrowthData("ja86ek")
+        object SerpAdClicked : GrowthData("")


Out of interest, how is the token name generated, and do UriLoaded and SerpAdClicked require token names adding?

The token name is generated in the Adjust web app, usually by the marketing/data team. I will wait to land this until those strings have been delivered. Without the tokens, I assume sending the events to the Adjust backend will be no-ops

Gotcha, thanks 👍

app/src/main/java/org/mozilla/fenix/components/metrics/MetricsStorage.kt

app/src/test/java/org/mozilla/fenix/components/metrics/DefaultMetricsStorageTest.kt

t-p-white

Just a few nits from my perspective. Maybe useful to have someone with more experience in this area also take a look. My concern is if I've missed any cases where an event should be being handled elsewhere.

jonalmeida

Thanks for the quick turnaround, this looks good to me.

MatthewTighe · 2023-01-07T22:52:23Z

@Mergifyio backport releases_v109.0.0

mergify · 2023-01-07T22:53:05Z

backport releases_v109.0.0

✅ Backports have been created

#28449 For #28428: update growth data with new events (backport #28429) has been created for branch releases_v109.0.0

…8429

(cherry picked from commit 7d84c53) # Conflicts: # app/src/main/java/org/mozilla/fenix/components/metrics/Event.kt # app/src/main/java/org/mozilla/fenix/components/metrics/MetricsStorage.kt # app/src/main/java/org/mozilla/fenix/telemetry/TelemetryMiddleware.kt # app/src/main/java/org/mozilla/fenix/utils/Settings.kt # app/src/main/res/values/preference_keys.xml # app/src/test/java/org/mozilla/fenix/components/metrics/DefaultMetricsStorageTest.kt # app/src/test/java/org/mozilla/fenix/telemetry/TelemetryMiddlewareTest.kt

(cherry picked from commit 7d84c53)

(cherry picked from commit 7d84c53) Co-authored-by: MatthewTighe <matthewdtighe@gmail.com>

…mobile/fenix#28429

…mobile/fenix#28429 (mozilla-mobile/fenix#28750) (cherry picked from commit 11227fa) Co-authored-by: MatthewTighe <matthewdtighe@gmail.com>

MatthewTighe requested review from a team as code owners January 6, 2023 00:28