This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #2899 - Scroll to Collections on change, animate new collections #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekager
force-pushed
the
new-collection-anim
branch
from
9e18917
to
0697749
Compare
| @@ -732,18 +739,56 @@ class HomeFragment : Fragment(), CoroutineScope, AccountObserver { | |||
| emitAccountChanges() | |||
| } | |||
|
|
|||
| private fun scrollToCollections(addedTabsSize: Int) { | |||
| launch(Dispatchers.Main) { | |||
There was a problem hiding this comment.
Using Dispatchers.Main directly like this means there is no coroutineScope Job to handle cancellation. The fragment has a coroutineContext using Main already that will cancel and the delay() method will cooperatively cancel when it does so. Is there a reason not to use the current context and to create a new coroutineScope instead?
There was a problem hiding this comment.
Does this change work @colintheshots ?
ekager
force-pushed
the
new-collection-anim
branch
from
0697749
to
138ca23
Compare
colintheshots
suggested changes
Jun 10, 2019
| @@ -481,6 +484,10 @@ class HomeFragment : Fragment(), CoroutineScope, AccountObserver { | |||
| } | |||
| } | |||
| } | |||
| launch(Dispatchers.Main) { | |||
There was a problem hiding this comment.
Please remove this dispatcher override here. Once this is done, I think we're ready to merge.
There was a problem hiding this comment.
Oops missed this one. Got it!
ekager
force-pushed
the
new-collection-anim
branch
from
138ca23
to
df4ab2b
Compare
colintheshots
approved these changes
Jun 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist