Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #3869 - Creates a SearchLocalizationProvider that sets the region… #3870

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

boek
Copy link
Contributor

@boek boek commented Jul 3, 2019

… to get the correct default search engine based on a locale

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

boek added 2 commits July 3, 2019 07:40
…ets the region to get the correct default search engine based on a locale
@boek boek requested a review from a team as a code owner July 3, 2019 14:41
Copy link
Contributor

@pocmo pocmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boek boek merged commit 18a7e80 into mozilla-mobile:master Jul 3, 2019
@boek boek deleted the i3869-se_locales branch July 3, 2019 16:45
@ghost ghost added this to the 1.0.1 milestone Jul 4, 2019
@sv-ohorvath
Copy link
Contributor

Partially fixed on RC 1.0.1. See #3869 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants