This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

[Bug] Fenix not setting default search engine properly #3869

Closed

boek opened this issue Jul 3, 2019 · 16 comments

Assignees

Labels

🐞 bug E5 Feature:SearchProvider P1

Milestone

Contributor

boek commented Jul 3, 2019 •

edited by data-sync-user

Steps to reproduce

Set locale to RU or CN

Expected behavior

Default search engine is not Google

Actual behavior

Default search engine is Google

Device information

any

┆Issue is synchronized with this Jira Task

boek added the 🐞 bug label

pocmo mentioned this issue

Implement SearchEngineProvider using MLS mozilla-mobile/android-components#3637

Closed

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Creates a SearchLocalizationProvider that s…

ae759c6

…ets the region to get the correct default search engine based on a locale

boek added this to the 1.0.1 milestone

boek self-assigned this

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Creates a SearchLocalizationProvider that s…

4c9ef81

…ets the region to get the correct default search engine based on a locale

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Adds a changelog entry

a9d9840

boek added a commit that referenced this issue


          For #3869 - Creates a SearchLocalizationProvider that sets the region…

… to get the correct default search engine based on a locale

boek added a commit that referenced this issue


          For #3869 - Adds a changelog entry

18a7e80

ekager added the eng:qa:needed label

AndiAJ added in progress and removed eng:qa:needed labels

Collaborator

AndiAJ commented Jul 4, 2019

Hi, I can still reproduce this issue on the latest Fenix Build #11850611 from 4/7 using a Google Pixel 3XL (Android 9) as it follows:

Russian ✅ OK - Yandex

► Settings:

► Fenix default search engines:

Chinese Traditional 1st option ❌NOK - Google

► Settings:

► Fenix default search engines:

Chinese Traditional 2nd option ❌NOK - Google

► Settings:

► Fenix default search engines:

Chinese Traditional 3rd option ❌NOK - Google

► Settings:

► Fenix default search engines:

Chinese Standard 1st option ✅ OK - Baidu

► Settings:

► Fenix default search engines:

Chinese Standard 2nd option ❌NOK - Google

► Settings:

► Fenix default search engines:

Chinese Standard 3rd option ❌NOK - Google

► Settings:

► Fenix default search engines:

Chinese Standard 4th option ❌NOK - Google

► Settings:

► Fenix default search engines:

@boek For each of the above mentioned languages you'll find attached pictures from the device settings as well as from Fenix.
Also, I'm not sure if for each Chinese language (Traditional or Standard) and their options should be also covered?

ghost removed this from the 1.0.1 milestone

st3fan pushed a commit that referenced this issue


          For #3869 - Creates a SearchLocalizationProvider that sets the region…

f459908

… to get the correct default search engine based on a locale

sv-ohorvath mentioned this issue

For #3869 - Creates a SearchLocalizationProvider that sets the region… #3870

Merged

4 tasks

vesta0 added this to the 1.1 Backlog milestone

vesta0 added the Feature:SearchProvider label

vesta0 added this to In Progress in Fenix Sprint Kanban

boek added the needs:ac label

Contributor Author

boek commented Jul 10, 2019 •

edited

Pt 2 waiting on: mozilla-mobile/android-components#3637

Contributor

liuche commented Jul 17, 2019 •

edited

Half of this has been done and fixed, but waiting for more permanent location search-engine from AC.

Will remove from sprint.

liuche moved this from In Progress to Sprint Backlog in Fenix Sprint Kanban

vesta0 added the P1 label

sblatz moved this from Sprint Backlog to In Progress in Fenix Sprint Kanban

boek added the 🙅 waiting label

boek moved this from In Progress to Waiting in Fenix Sprint Kanban

sblatz removed the in progress label

vesta0 removed this from the 1.1 Backlog milestone

bifleming removed this from Waiting in Fenix Sprint Kanban

sblatz assigned sblatz and boek

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Uses RegionSearchLocalizationProvider in th…

cffa7c2

…e search engine provider

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Uses RegionSearchLocalizationProvider in th…

4ef5da1

…e search engine provider

boek moved this from Sprint Backlog to In Dev Review in Fenix Sprint Kanban

boek modified the milestones: v3.1, v3.2

liuche pushed a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Uses RegionSearchLocalizationProvider in th…

d818cc0

…e search engine provider

boek added the eng:qa:needed label

Member

abodea commented Feb 3, 2020 •

edited

Hello, @boek @vesta0 is there a list where I can see what default search engine should be displayed for each language?
I synced with Severin on slack but he couldn't help me.
Note that for Chinese Traditional now is not Google displayed, but it's Bing. Before moving forward with the verification I wanted to make sure I have the right list for each language.
I will remove the qa needed until further notice.

abodea removed the eng:qa:needed label

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Uses RegionSearchLocalizationProvider in th…

3ade102

…e search engine provider

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Fixes unit tests

3b80fa1

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Uses RegionSearchLocalizationProvider in th…

db52c76

…e search engine provider

boek added a commit to boek/fenix that referenced this issue


          For mozilla-mobile#3869 - Fixes unit tests

976235d

boek added a commit that referenced this issue


          For #3869 - Uses RegionSearchLocalizationProvider in the search engin…

a874632

…e provider

boek added a commit that referenced this issue


          For #3869 - Fixes unit tests

c1f0e7b

Diana-Rus mentioned this issue

[Bug] (regression) Google (and other engines) missing in other languages #6981

Closed

sblatz removed their assignment

liuche removed this from In Dev Review in Fenix Sprint Kanban

Contributor

liuche commented Mar 31, 2020

@Flod do you know where the default search engine is listed per-locale?

liuche added this to In Dev Review in Fenix Sprint Kanban

Collaborator

vesta0 commented Apr 20, 2020

Can we find out which devices or locales are impacted by this bug?

vesta0 added the needs:group-triage label

eliserichards removed the needs:group-triage label

bifleming removed this from Items needed for Fenix Q4 2019 in Fenix: A-S Bugs

liuche removed this from In Dev Review in Fenix Sprint Kanban

Contributor

sv-ohorvath commented Jul 14, 2020

@vesta0 Does this need QA investigation? If so, we could add the QA:needed label and have someone look at it.

Contributor

liuche commented Jul 17, 2020

This seems like the same STR as #12544 which was verified, so I'm going to close this as a dupe

liuche closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.