This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
No issue: Enable Strict Mode in Debug Builds #4014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colintheshots
force-pushed
the
strictMode
branch
from
ad09709
to
8e73aba
Compare
ekager
approved these changes
Jul 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling strict mode in debug builds should help with catching performance issues early where we forget to background long-running work and block the main thread instead. It should also help with catching non-SDK APIs we're using that are likely to go away soon. LogCat should get a lot more noisy after this change for Debug builds, but it's useful information to fix real problems.
Pull Request checklist