This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #3443 - convert textPercentageSeekBar to Kotlin #4081
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colintheshots
suggested changes
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the contribution. As written, the new KDoc breaks the descriptions in the IDE. Instead of two or three getter and setter descriptions, we need a single description for each property.
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Show resolved
Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt
Show resolved
Hide resolved
@nikit19 awesome, thank you! 🎉 |
@colintheshots Thank you for the feedback. I have addressed the requested changes. If I missed something, please let me know. |
@colintheshots @boek Could you please review. I will happily make the changes if there are any changes to be done. |
colintheshots
approved these changes
Jul 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist