Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #3443 - convert textPercentageSeekBar to Kotlin #4081

Merged
merged 6 commits into from
Jul 30, 2019
Merged

For #3443 - convert textPercentageSeekBar to Kotlin #4081

merged 6 commits into from
Jul 30, 2019

Conversation

nikit19
Copy link
Contributor

@nikit19 nikit19 commented Jul 16, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@nikit19 nikit19 requested a review from a team as a code owner July 16, 2019 15:57
@nikit19
Copy link
Contributor Author

nikit19 commented Jul 16, 2019

Hi @boek
I was not able to reopen the pull request ( #3444 ) so I made new PR after resolving the conflicts.

colintheshots
colintheshots suggested changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate the contribution. As written, the new KDoc breaks the descriptions in the IDE. Instead of two or three getter and setter descriptions, we need a single description for each property.

app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Outdated Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Show resolved Hide resolved
app/src/main/java/org/mozilla/fenix/settings/TextPercentageSeekBarPreference.kt Show resolved Hide resolved
@boek
Copy link
Contributor

boek commented Jul 16, 2019

@nikit19 awesome, thank you! 🎉

@nikit19
Copy link
Contributor Author

nikit19 commented Jul 17, 2019

@colintheshots Thank you for the feedback. I have addressed the requested changes. If I missed something, please let me know.

@boek boek requested a review from colintheshots July 19, 2019 00:27
@nikit19
Copy link
Contributor Author

nikit19 commented Jul 29, 2019

@colintheshots @boek Could you please review. I will happily make the changes if there are any changes to be done.

@colintheshots colintheshots merged commit 5e52fc4 into mozilla-mobile:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@colintheshots colintheshots colintheshots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikit19 @boek @colintheshots