Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #1750: Adds gradient to private BrowserToolbar #4361

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Jul 29, 2019

Also updates the color of quickActionSheet ot be "above" attribute

Old neutral color divider lines:
image

New neutral color divider lines:
image

@sblatz sblatz requested a review from a team as a code owner July 29, 2019 20:22
@sblatz
Copy link
Contributor Author

sblatz commented Jul 29, 2019

@brampitoyo to confirm if these divider lines look right :)

@sblatz sblatz requested a review from brampitoyo July 29, 2019 20:26
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice change.

@brampitoyo
Copy link

brampitoyo commented Jul 29, 2019

Looks good to me.

Sorry. Just one correction. I went to the Sketch file and examined the real colour value. I found that the divider line value is #fbfbfe at 12% opacity.

Converted to ARGB, that’s #1ffbfbfe.

@brampitoyo
Copy link

Please see small colour value correction up above before merging. Sorry!

Also updates the color of quickActionSheet ot be "above" attribute
@sblatz sblatz force-pushed the private-mode-color-update branch from c8061c9 to 0e5b48f Compare July 30, 2019 15:16
@sblatz sblatz merged commit 437ecfb into mozilla-mobile:master Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants