Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update Private Browsing theme to match new design #1750

Closed
brampitoyo opened this issue Apr 18, 2019 · 8 comments
Closed

Update Private Browsing theme to match new design #1750

brampitoyo opened this issue Apr 18, 2019 · 8 comments
Assignees
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PrivateBrowsing
Milestone

Comments

@brampitoyo
Copy link

brampitoyo commented Apr 18, 2019

Mockups

https://mozilla.invisionapp.com/share/9QRLVJI8UZK

Colour values

Primary Text Second Text Foundation Above Above dark Accent Accent Bright Neutral
#FBFBFE (same as dark theme) #A7A2B7 (same as dark theme) linear-gradient(45deg, #7529A7 0%, #492E85 50%, #383372 100%); #291D4F Please generate this #722291 #F565FF #B1B1B3 (same as dark theme)

View these values alongside light and dark themes in the Color Audit document.

Private Browsing Mode settings doesn’t use its own theme. It follows the theme that has been set in the app.

CC @sblatz @mheubusch and @AmyYLee

┆Issue is synchronized with this Jira Task

@brampitoyo brampitoyo added this to the MVP Backlog milestone Apr 18, 2019
@vesta0 vesta0 added P2 Upcoming release and removed P1 Current sprint labels May 8, 2019
@vesta0 vesta0 modified the milestones: MVP Backlog, Fenix 1.1 Backlog May 23, 2019
@vesta0 vesta0 removed P2 Upcoming release labels Jun 7, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 3, 2019

Updated link to spec https://mozilla.invisionapp.com/share/YFR8WRD8WJ9

@sblatz
Copy link
Contributor

sblatz commented Jul 3, 2019

We're timeboxing this to a 3 so we don't spend too much time trying to get the toolbar looking correct with the gradient.

This does not include adding the trash can button back or the "delete session" button as we've decided to not move forward.

@sblatz sblatz self-assigned this Jul 8, 2019
@sblatz
Copy link
Contributor

sblatz commented Jul 8, 2019

Can I get some clarification on which of these colors I should be using for card highlights?
image
image

Also, the card highlight color should match the button colors used throughout (as it does in light and dark theme). So keep in mind this color will be used for those too!

cc: @AmyYLee

@sblatz sblatz added 🙅 waiting Issues that are blocked or has dependencies that are not ready and removed in progress 🙅 waiting Issues that are blocked or has dependencies that are not ready labels Jul 8, 2019
@sblatz sblatz added the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 8, 2019
@AmyYLee
Copy link
Collaborator

AmyYLee commented Jul 9, 2019

@sblatz Hi! Can we update the highlight colour for PBM to be the same as the new Dark theme update for "Buttons"? Color: Violet 50 (#9059FF). Please see #1944 I think this simplifies things by having the same colour for buttons/toggles,switches/highlight tab colour for Dark theme and PBM.

Screen Shot 2019-07-09 at 5 01 54 PM

@sblatz sblatz removed the 🙅 waiting Issues that are blocked or has dependencies that are not ready label Jul 10, 2019
@abodea
Copy link
Member

abodea commented Jul 24, 2019

Verified as fixed in the latest Nightly build from 7/24(190724(Build #12050609)) with Samsung Galaxy s10+(Android 9).
Screenshot_20190724-154028_Firefox Preview
Screenshot_20190724-154021_Firefox Preview

@sblatz can you please confirm that my verification is correct? I wanna make sure I understood correctly. The card that contain the URL should also be modified with this change?

@abodea abodea closed this as completed Jul 24, 2019
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 24, 2019
@brampitoyo
Copy link
Author

@sblatz @abodea Just noting the fact that the Private Browsing toolbar should also have a gradient, in addition to the homescreen background: https://mozilla.invisionapp.com/share/DST592EZKRP

Should this issue be reopened?

@abodea
Copy link
Member

abodea commented Jul 25, 2019

@brampitoyo I just verified with the latest Nightly build from 7/25 and the Private Browsing toolbar doesn't have a gradient, I will re-open this issue until it will be fixed.
Thank you!

@abodea abodea reopened this Jul 25, 2019
@abodea abodea removed the eng:qa:verified QA Verified label Jul 25, 2019
sblatz added a commit to sblatz/fenix that referenced this issue Jul 29, 2019
Also updates the color of quickActionSheet ot be "above" attribute
sblatz added a commit to sblatz/fenix that referenced this issue Jul 30, 2019
Also updates the color of quickActionSheet ot be "above" attribute
sblatz added a commit that referenced this issue Jul 30, 2019
Also updates the color of quickActionSheet ot be "above" attribute
@sblatz sblatz added the eng:qa:needed QA Needed label Jul 30, 2019
@abodea
Copy link
Member

abodea commented Jul 31, 2019

Verified as fixed on the latest Nightly 7/31 with Samsung Galaxy s10+(Android 9).

@abodea abodea closed this as completed Jul 31, 2019
@abodea abodea added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Jul 31, 2019
@boek boek modified the milestones: 1.1 Backlog, v1.2 Aug 1, 2019
@data-sync-user data-sync-user changed the title Update Private Browsing theme to match new design FNX2-17383 ⁃ Update Private Browsing theme to match new design Aug 4, 2020
@data-sync-user data-sync-user changed the title FNX2-17383 ⁃ Update Private Browsing theme to match new design FNX3-15795 ⁃ Update Private Browsing theme to match new design Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX3-15795 ⁃ Update Private Browsing theme to match new design FNX-5227 ⁃ Update Private Browsing theme to match new design Aug 11, 2020
@data-sync-user data-sync-user changed the title FNX-5227 ⁃ Update Private Browsing theme to match new design Update Private Browsing theme to match new design May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
E3 Estimation Point: average, 2 - 3 days eng:qa:verified QA Verified Feature:PrivateBrowsing
Projects
None yet
Development

No branches or pull requests

7 participants