Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Extract quick action sheet observer code #4368

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

NotWoods
Copy link
Contributor

Move out the session and session manager observers into its own class.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@NotWoods NotWoods added the eng:health Improve code health label Jul 30, 2019
@NotWoods NotWoods requested a review from a team as a code owner July 30, 2019 01:21
@NotWoods NotWoods force-pushed the quick-action-session-observer branch from b3046b0 to ea87ea4 Compare July 30, 2019 17:11
@NotWoods NotWoods mentioned this pull request Jul 30, 2019
4 tasks
@NotWoods NotWoods force-pushed the quick-action-session-observer branch from ea87ea4 to f54d643 Compare August 6, 2019 14:14
@NotWoods NotWoods requested a review from ekager August 6, 2019 14:15
@NotWoods NotWoods force-pushed the quick-action-session-observer branch from f54d643 to 99d1313 Compare August 13, 2019 17:51
@NotWoods NotWoods changed the title Extract quick action sheet observer code Extract quick action sheet observer code Aug 14, 2019
@NotWoods NotWoods force-pushed the quick-action-session-observer branch from 99d1313 to fa0b4c6 Compare August 14, 2019 15:42
@codecov-io
Copy link

Codecov Report

Merging #4368 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4368      +/-   ##
===========================================
- Coverage      6.69%   6.68%   -0.02%     
  Complexity      152     152              
===========================================
  Files           203     204       +1     
  Lines          8494    8493       -1     
  Branches       1189    1188       -1     
===========================================
- Hits            569     568       -1     
  Misses         7886    7886              
  Partials         39      39
Impacted Files Coverage Δ Complexity Δ
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...uickactionsheet/QuickActionSheetSessionObserver.kt 0% <0%> (ø) 0 <0> (?)
.../java/org/mozilla/fenix/browser/BrowserFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/ext/Context.kt 16% <0%> (-4%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1328d68...fa0b4c6. Read the comment docs.

@NotWoods NotWoods force-pushed the quick-action-session-observer branch from fa0b4c6 to 39aeb70 Compare August 14, 2019 17:35
@boek boek dismissed ekager’s stale review August 19, 2019 15:28

Changes have been made

@boek boek merged commit de14962 into mozilla-mobile:master Aug 19, 2019
@NotWoods NotWoods deleted the quick-action-session-observer branch January 25, 2020 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:health Improve code health
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants