Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Update fenix for new megazord setup #4391

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Update fenix for new megazord setup #4391

merged 2 commits into from
Aug 1, 2019

Conversation

thomcc
Copy link

@thomcc thomcc commented Jul 30, 2019

Depends on mozilla-mobile/android-components#3806

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@thomcc thomcc requested a review from a team as a code owner July 30, 2019 21:25
@thomcc
Copy link
Author

thomcc commented Jul 30, 2019

CC @hawkinsw After this you can defer JNA initialization (by deferring HTTP client init and logging init) the way you wanted to so long ago.

grigoryk
grigoryk reviewed Jul 30, 2019
View reviewed changes
build.gradle Outdated Show resolved Hide resolved
buildSrc/src/main/java/Dependencies.kt Outdated Show resolved Hide resolved
@eoger eoger mentioned this pull request Jul 30, 2019
Closed
@hawkinsw
Copy link
Contributor

CC @hawkinsw After this you can defer JNA initialization (by deferring HTTP client init and logging init) the way you wanted to so long ago.

This is great! Thank you so much for the hard work! @csadilek

@grigoryk
Copy link
Contributor

grigoryk commented Aug 1, 2019

mozilla-mobile/android-components#3806 landed in a-c 7.0.0. We'll need this PR when we update to 7.0.0.

@grigoryk grigoryk mentioned this pull request Aug 1, 2019
Merged
@grigoryk
Copy link
Contributor

grigoryk commented Aug 1, 2019

I think this needs at least two changes:

  • add the lost-in-a-rebase implementation Deps.mozilla_support_rusthttp
  • change a-c version to 7.0.0-SNAPSHOT

@thomcc thomcc force-pushed the full-megazord branch 2 times, most recently from 9e35851 to 4e8a703 Compare August 1, 2019 17:39
grigoryk
grigoryk approved these changes Aug 1, 2019
View reviewed changes
buildSrc/src/main/java/Dependencies.kt Show resolved Hide resolved
buildSrc/src/main/java/Dependencies.kt Outdated Show resolved Hide resolved
@grigoryk grigoryk merged commit 3253f01 into mozilla-mobile:master Aug 1, 2019
@rocketsroger rocketsroger mentioned this pull request Aug 15, 2019
Closed
@hawkinsw hawkinsw mentioned this pull request Sep 10, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@grigoryk grigoryk grigoryk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomcc @hawkinsw @grigoryk