This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #1744: Open search shortcuts when entering search mode #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we even still need this argument if it's defaulting to true now? Are there fragments that use the directions with |
No there isn't. I kept the argument just in case, but should I just get rid of it? |
|
I think you should get rid of the argument altogether if we don't use it anymore. Another part of #1744 was making sure these search shortcuts get dismissed as you start typing. Could you make sure that works as well? |
|
Yeah, the shortcuts get dismissed properly. I removed the argument, so let me know if there are other changes I should make! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist