Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fixes #4771 - Add method for sessions of type #4782

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

NotWoods
Copy link
Contributor

@NotWoods NotWoods commented Aug 16, 2019

Fixes share tabs to use the new method.

Long-term I want to uplift this to Android Components, but that'll probably happen with browser-state instead so this is a good quick fix.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@codecov-io
Copy link

codecov-io commented Aug 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@a65f220). Click here to learn what that means.
The diff coverage is 8.33%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4782   +/-   ##
========================================
  Coverage          ?   6.41%           
  Complexity        ?     154           
========================================
  Files             ?     206           
  Lines             ?    9012           
  Branches          ?    1338           
========================================
  Hits              ?     578           
  Misses            ?    8395           
  Partials          ?      39
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (?)
...enix/components/toolbar/TabCounterToolbarButton.kt 0% <0%> (ø) 0 <0> (?)
.../main/java/org/mozilla/fenix/ext/SessionManager.kt 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a65f220...036bdd5. Read the comment docs.

Fixes share tabs to use the new method
@boek boek merged commit d1964d6 into mozilla-mobile:master Aug 27, 2019
@NotWoods NotWoods deleted the sessions-of-type branch January 25, 2020 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants