Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

fixes #4179 removed control highlight from disconnect button #4806

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Aug 19, 2019

set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • [] Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

…utton

set colorControlHighlight to transparent in activity theme.
property cannot be set in view because it is overwritten by activity theme.
@mcarare mcarare requested a review from a team as a code owner August 19, 2019 12:32
@codecov-io
Copy link

Codecov Report

Merging #4806 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master   #4806      +/-   ##
===========================================
+ Coverage      6.37%   6.39%   +0.01%     
  Complexity      154     154              
===========================================
  Files           205     205              
  Lines          9022    9014       -8     
  Branches       1358    1358              
===========================================
+ Hits            575     576       +1     
+ Misses         8401    8392       -9     
  Partials         46      46
Impacted Files Coverage Δ Complexity Δ
...ug/java/org/mozilla/fenix/DebugFenixApplication.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/ext/Context.kt 20% <0%> (+4%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d02354...5b9fb45. Read the comment docs.

@boek boek merged commit bf42abb into mozilla-mobile:master Aug 19, 2019
@mcarare mcarare deleted the 4179 branch October 28, 2019 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants