Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4652 : Use workaround for HomeScreenViewModel #4887

Merged
merged 1 commit into from
Aug 22, 2019
Merged

For #4652 : Use workaround for HomeScreenViewModel #4887

merged 1 commit into from
Aug 22, 2019

Conversation

ekager
Copy link
Contributor

@ekager ekager commented Aug 22, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@ekager ekager requested a review from a team as a code owner August 22, 2019 18:21
colintheshots
colintheshots approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I hope this resolves the crashes we're seeing.

@colintheshots colintheshots merged commit 84b0693 into mozilla-mobile:master Aug 22, 2019
@ekager ekager deleted the view-model-workaround branch August 21, 2020 20:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@colintheshots colintheshots colintheshots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ekager @colintheshots