Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #4652 : Use workaround for HomeScreenViewModel #4887

Merged
merged 1 commit into from
Aug 22, 2019
Merged

For #4652 : Use workaround for HomeScreenViewModel #4887

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,9 @@ class HomeFragment : Fragment(), AccountObserver {
super.onViewCreated(view, savedInstanceState)

FragmentPreDrawManager(this).execute {
val homeViewModel: HomeScreenViewModel by activityViewModels()
val homeViewModel: HomeScreenViewModel by activityViewModels {
ViewModelProvider.NewInstanceFactory() // this is a workaround for #4652
}
homeViewModel.layoutManagerState?.also { parcelable ->
sessionControlComponent.view.layoutManager?.onRestoreInstanceState(parcelable)
}
Expand Down Expand Up @@ -514,7 +516,9 @@ class HomeFragment : Fragment(), AccountObserver {
override fun onPause() {
invokePendingDeleteJobs()
super.onPause()
val homeViewModel: HomeScreenViewModel by activityViewModels()
val homeViewModel: HomeScreenViewModel by activityViewModels {
ViewModelProvider.NewInstanceFactory() // this is a workaround for #4652
}
homeViewModel.layoutManagerState =
sessionControlComponent.view.layoutManager?.onSaveInstanceState()
homeViewModel.motionLayoutProgress = homeLayout?.progress ?: 0F
Expand Down