This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #4897: Add back accidentally removed code coverage upload #4958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchhentges
approved these changes
Aug 27, 2019
automation/taskcluster/lib/tasks.py
Outdated
| @@ -141,8 +141,23 @@ def craft_assemble_pr_task(self, variant): | |||
| } | |||
| ) | |||
|
|
|||
| def craft_test_pr_task(self, variant): | |||
| command = 'test{}UnitTest'.format(variant.name) | |||
| def craft_test_pr_task(self, variant, run_coverage=True): | |||
There was a problem hiding this comment.
If run_coverage always has the same value (True, I believe) I'd recommend inlining it
mitchhentges
approved these changes
Aug 27, 2019
Codecov Report
@@ Coverage Diff @@
## master #4958 +/- ##
========================================
Coverage ? 8.08%
Complexity ? 176
========================================
Files ? 222
Lines ? 9017
Branches ? 1321
========================================
Hits ? 729
Misses ? 8236
Partials ? 52Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code coverage upload was accidentally removed with the changes to Nightly builds.
Pull Request checklist