-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #4897: Add back accidentally removed code coverage upload #4958
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this back!
automation/taskcluster/lib/tasks.py
Outdated
@@ -141,8 +141,23 @@ def craft_assemble_pr_task(self, variant): | |||
} | |||
) | |||
|
|||
def craft_test_pr_task(self, variant): | |||
command = 'test{}UnitTest'.format(variant.name) | |||
def craft_test_pr_task(self, variant, run_coverage=True): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If run_coverage
always has the same value (True
, I believe) I'd recommend inlining it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 beautiful, thanks!
Codecov Report
@@ Coverage Diff @@
## master #4958 +/- ##
========================================
Coverage ? 8.08%
Complexity ? 176
========================================
Files ? 222
Lines ? 9017
Branches ? 1321
========================================
Hits ? 729
Misses ? 8236
Partials ? 52 Continue to review full report at Codecov.
|
Code coverage upload was accidentally removed with the changes to Nightly builds.
Pull Request checklist