Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5277: Updates string for delete browsing data #5309

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Sep 13, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

@sblatz sblatz requested review from a team as code owners September 13, 2019 16:45
@sblatz sblatz added the needs:uplift Issue / PR needs to be uplifted to the release branch label Sep 13, 2019
@codecov-io
Copy link

Codecov Report

Merging #5309 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5309   +/-   ##
=========================================
  Coverage     11.91%   11.91%           
  Complexity      245      245           
=========================================
  Files           247      247           
  Lines         10234    10234           
  Branches       1511     1511           
=========================================
  Hits           1219     1219           
  Misses         8935     8935           
  Partials         80       80
Impacted Files Coverage Δ Complexity Δ
...g/mozilla/fenix/library/history/HistoryFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...zilla/fenix/settings/DeleteBrowsingDataFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd85229...29e1321. Read the comment docs.

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #5309 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5309   +/-   ##
=========================================
  Coverage     11.91%   11.91%           
  Complexity      245      245           
=========================================
  Files           247      247           
  Lines         10234    10234           
  Branches       1511     1511           
=========================================
  Hits           1219     1219           
  Misses         8935     8935           
  Partials         80       80
Impacted Files Coverage Δ Complexity Δ
...g/mozilla/fenix/library/history/HistoryFragment.kt 0% <ø> (ø) 0 <0> (ø) ⬇️
...zilla/fenix/settings/DeleteBrowsingDataFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd85229...29e1321. Read the comment docs.

@sblatz sblatz merged commit e247870 into mozilla-mobile:master Sep 13, 2019
@ekager ekager removed the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants