This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #5898: Launch SUMO article properly for default browser #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sblatz
added
the
needs:uplift
Issue / PR needs to be uplifted to the release branch
label
Oct 11, 2019
colintheshots
approved these changes
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
bors r+ |
Build failed
|
Codecov Report
@@ Coverage Diff @@
## master #5973 +/- ##
============================================
- Coverage 14.26% 14.25% -0.02%
+ Complexity 324 320 -4
============================================
Files 259 258 -1
Lines 10694 10686 -8
Branches 1558 1557 -1
============================================
- Hits 1526 1523 -3
+ Misses 9043 9037 -6
- Partials 125 126 +1
Continue to review full report at Codecov.
|
bors retry |
Build succeeded
|
boek
pushed a commit
to boek/fenix
that referenced
this pull request
Oct 16, 2019
5973: For mozilla-mobile#5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
ekager
removed
the
needs:uplift
Issue / PR needs to be uplifted to the release branch
label
Oct 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally this SUMO article would get opened, but the user didn't get pushed to the browser fragment since I accidentally was navigating from the wrong screen.
Pull Request checklist
After merge
To download an APK when reviewing a PR: