Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #5898: Launch SUMO article properly for default browser #5973

Merged
merged 1 commit into from Oct 14, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 11, 2019


Originally this SUMO article would get opened, but the user didn't get pushed to the browser fragment since I accidentally was navigating from the wrong screen.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz added the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 11, 2019
Copy link
Contributor

@colintheshots colintheshots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@colintheshots
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Oct 14, 2019
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
@bors
Copy link

bors bot commented Oct 14, 2019

Build failed

  • test-ui

@codecov-io
Copy link

codecov-io commented Oct 14, 2019

Codecov Report

Merging #5973 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5973      +/-   ##
============================================
- Coverage     14.26%   14.25%   -0.02%     
+ Complexity      324      320       -4     
============================================
  Files           259      258       -1     
  Lines         10694    10686       -8     
  Branches       1558     1557       -1     
============================================
- Hits           1526     1523       -3     
+ Misses         9043     9037       -6     
- Partials        125      126       +1
Impacted Files Coverage Δ Complexity Δ
...a/fenix/settings/DefaultBrowserSettingsFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...pp/src/main/java/org/mozilla/fenix/FeatureFlags.kt 91.66% <0%> (-8.34%) 2% <0%> (ø)
...x/home/sessioncontrol/viewholders/TabViewHolder.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...main/java/org/mozilla/fenix/components/Services.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
app/src/main/java/org/mozilla/fenix/Config.kt 0% <0%> (ø) 0% <0%> (ø) ⬇️
...ain/java/org/mozilla/fenix/components/FxaServer.kt
...org/mozilla/fenix/components/BackgroundServices.kt 47.57% <0%> (+1.57%) 4% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b6c752...2395b9b. Read the comment docs.

@sblatz
Copy link
Contributor Author

sblatz commented Oct 14, 2019

bors retry

bors bot pushed a commit that referenced this pull request Oct 14, 2019
5973: For #5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
@bors
Copy link

bors bot commented Oct 14, 2019

Build succeeded

  • build-debug
  • lint-compare-locales
  • lint-detekt
  • lint-ktlint
  • lint-lint
  • test-debug
  • test-ui

@bors bors bot merged commit 2395b9b into mozilla-mobile:master Oct 14, 2019
boek pushed a commit to boek/fenix that referenced this pull request Oct 16, 2019
5973: For mozilla-mobile#5898: Launch SUMO article properly for default browser r=colintheshots a=sblatz



Co-authored-by: Sawyer Blatz <sdblatz@gmail.com>
@ekager ekager removed the needs:uplift Issue / PR needs to be uplifted to the release branch label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants