Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Add verify items tests for settings menus #6059

Merged
merged 1 commit into from Oct 21, 2019
Merged

Add verify items tests for settings menus #6059

merged 1 commit into from Oct 21, 2019

Conversation

rpappalax
Copy link
Contributor

@rpappalax rpappalax commented Oct 16, 2019 •
edited

Also closes #6006

All UI tests are passing with the exception of 1 which was just uncovered by a new test in this PR. Issue here:
#6053

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@rpappalax rpappalax added the eng:automation Build automation, Continuous integration, .. label Oct 16, 2019
@codecov-io
Copy link

codecov-io commented Oct 16, 2019 •
edited

Codecov Report

Merging #6059 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6059   +/-   ##
=========================================
  Coverage     14.32%   14.32%           
  Complexity      326      326           
=========================================
  Files           261      261           
  Lines         10725    10725           
  Branches       1565     1565           
=========================================
  Hits           1536     1536           
  Misses         9065     9065           
  Partials        124      124

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d575c25...744d177. Read the comment docs.

kglazko
kglazko approved these changes Oct 16, 2019
View reviewed changes
Copy link
Contributor

@kglazko kglazko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nit: The changes in automation/taskcluster and taskcluster/docker seem not directly related to the settings menu tests and could be in their own PR but not necessary.

@rpappalax rpappalax force-pushed the 3dot-menu-main-basics-test branch 2 times, most recently from 001dffb to 3ed3122 Compare October 17, 2019 16:39
@rpappalax rpappalax added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Oct 17, 2019
@rpappalax rpappalax force-pushed the 3dot-menu-main-basics-test branch 4 times, most recently from e93b447 to 5a2626b Compare October 21, 2019 15:18
@rpappalax rpappalax removed the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Oct 21, 2019
@rpappalax
Copy link
Contributor Author

bors r=kglazko

bors bot pushed a commit that referenced this pull request Oct 21, 2019
@MozLando @rpappalax
Merge #6059
fed0c88 
6059: Add verify items tests for settings menus r=kglazko a=rpappalax

Also closes #6006

All UI tests are passing with the exception of 1 which was just uncovered by a new test in this PR.  Issue here:
#6053



Co-authored-by: Richard Pappalardo <rpappalax@gmail.com>
@bors
Copy link

bors bot commented Oct 21, 2019

Build succeeded

  • lint-ktlint
  • test-ui
  • build-debug
  • test-debug
  • lint-lint
  • lint-detekt
  • lint-compare-locales

@bors bors bot merged commit 744d177 into master Oct 21, 2019
@bors bors bot deleted the 3dot-menu-main-basics-test branch October 21, 2019 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kglazko kglazko kglazko approved these changes

Assignees
No one assigned
Labels
eng:automation Build automation, Continuous integration, ..
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set flank version in ui-test/Dockerfile as ENV var
3 participants
@rpappalax @codecov-io @kglazko