Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Closes #4775 - Update README with Severity Triage process #6311

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

liuche
Copy link
Contributor

@liuche liuche commented Oct 29, 2019


Updating README to explain quick severity triage process.

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@liuche liuche requested a review from sblatz October 29, 2019 01:09
@codecov-io
Copy link

codecov-io commented Oct 29, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@905c785). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6311   +/-   ##
=========================================
  Coverage          ?   14.49%           
  Complexity        ?      323           
=========================================
  Files             ?      272           
  Lines             ?    11039           
  Branches          ?     1593           
=========================================
  Hits              ?     1600           
  Misses            ?     9311           
  Partials          ?      128

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 905c785...eab26e6. Read the comment docs.

Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for adding this 😄

@sblatz sblatz merged commit 104e3ad into mozilla-mobile:master Oct 30, 2019
@liuche liuche deleted the readme-issues branch October 31, 2019 01:33
@severinrudie severinrudie mentioned this pull request Nov 6, 2019
30 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants