Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6992, for #6897, for #6889: Disable multitouch in app #6999

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

mcarare
Copy link
Contributor

@mcarare mcarare commented Dec 6, 2019


Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@mcarare
Copy link
Contributor Author

mcarare commented Dec 6, 2019

IMO the only place Fenix needs multitouch is in browser window. This change does not affect zooming or multiple touches inside engineView, because it prevents multiple touches in a ViewGroupnot in a single View.
Also , I tested zoom and multitouch inside browser window and they still work.

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #6999 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6999   +/-   ##
========================================
  Coverage      18.6%   18.6%           
  Complexity      413     413           
========================================
  Files           282     282           
  Lines         11165   11165           
  Branches       1524    1524           
========================================
  Hits           2077    2077           
  Misses         8926    8926           
  Partials        162     162

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300d831...f84e44c. Read the comment docs.

@sblatz sblatz self-assigned this Dec 19, 2019
@sblatz sblatz self-requested a review December 19, 2019 21:13
Copy link
Contributor

@sblatz sblatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 😄

@sblatz sblatz added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Dec 19, 2019
@sblatz sblatz merged commit c5a142a into mozilla-mobile:master Dec 20, 2019
@mcarare mcarare deleted the multi-touch branch June 3, 2020 10:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants