Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Fix 5366 - Use VectorDrawableCompat for all imagery #7221

Merged
merged 3 commits into from
Dec 17, 2019

Conversation

darkwing
Copy link
Contributor


Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Dec 16, 2019

Codecov Report

Merging #7221 into master will decrease coverage by 0.01%.
The diff coverage is 5%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7221      +/-   ##
============================================
- Coverage     18.95%   18.94%   -0.02%     
  Complexity      436      436              
============================================
  Files           288      288              
  Lines         11282    11290       +8     
  Branches       1538     1538              
============================================
  Hits           2139     2139              
- Misses         8981     8989       +8     
  Partials        162      162
Impacted Files Coverage Δ Complexity Δ
...x/search/awesomebar/ShortcutsSuggestionProvider.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...kmarks/selectfolder/SelectBookmarkFolderAdapter.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../java/org/mozilla/fenix/utils/ClearableEditText.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../bookmarks/viewholders/BookmarkFolderViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...la/fenix/settings/quicksettings/WebsiteInfoView.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...x/home/sessioncontrol/viewholders/TabViewHolder.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...main/java/org/mozilla/fenix/settings/Extensions.kt 4.76% <0%> (ø) 0 <0> (ø) ⬇️
...downloads/DownloadNotificationBottomSheetDialog.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ozilla/fenix/collections/CollectionCreationView.kt 34.1% <50%> (ø) 6 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90c7751...66dd099. Read the comment docs.

Copy link
Contributor

@severinrudie severinrudie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a very safe PR, and if we missed anything we can always follow up. I'm a little more concerned about maintaining this standard going forward though. We should probably look into a linter that will enforce this; these seem like very easy mistakes to make.

app/src/main/java/org/mozilla/fenix/settings/Extensions.kt Outdated Show resolved Hide resolved
@NotWoods NotWoods merged commit e727ae5 into mozilla-mobile:master Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants