Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Import strings from android-l10n #7744

Merged

Conversation

mozilla-l10n-automation-bot
Copy link
Collaborator

n/t

@firefoxci-taskcluster
Copy link

No Taskcluster jobs started for this pull request
The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

@mcarare mcarare changed the title Import strings from android-l10n. Import strings from android-l10n. Jan 16, 2020
@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #7744 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7744      +/-   ##
============================================
+ Coverage     19.17%   19.18%   +0.01%     
  Complexity      452      452              
============================================
  Files           301      301              
  Lines         11664    11642      -22     
  Branches       1583     1579       -4     
============================================
- Hits           2236     2234       -2     
+ Misses         9244     9223      -21     
- Partials        184      185       +1
Impacted Files Coverage Δ Complexity Δ
...mponents/searchengine/FenixSearchEngineProvider.kt 60.27% <0%> (-2.74%) 10% <0%> (ø)
...a/org/mozilla/gecko/search/SearchWidgetProvider.kt 1.92% <0%> (+0.57%) 1% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffb2e72...4108342. Read the comment docs.

@mozilla-l10n-automation-bot mozilla-l10n-automation-bot changed the title Import strings from android-l10n. Import strings from android-l10n. Jan 17, 2020
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New locales!

@liuche
Copy link
Contributor

liuche commented Jan 18, 2020

Doesn't seem related 🤔 , and only fails on Nexus 6, r25

androidx.test.espresso.base.DefaultFailureHandler$AssertionFailedWithCauseError: 'with text: a string containing "http://localhost:60312/pages/generic3.html"' doesn't match the selected view.
Expected: with text: a string containing "http://localhost:60312/pages/generic3.html"
Got: "TextView{id=2131296902, res-name=mozac_browser_toolbar_url_view, visibility=VISIBLE, width=834, height=140, has-focus=false, has-focusable=true, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=false, is-selected=false, layout-params=android.widget.LinearLayout$LayoutParams@5c9320e, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=http://localhost:60312/pages/generic4.html, hint=Search or enter address, input-type=0, ime-target=false, has-links=false}"

at dalvik.system.VMStack.getThreadStackTrace(Native Method)
at java.lang.Thread.getStackTrace(Thread.java:1566)
at androidx.test.espresso.base.DefaultFailureHandler.getUserFriendlyError(DefaultFailureHandler.java:96)
at androidx.test.espresso.base.DefaultFailureHandler.handle(DefaultFailureHandler.java:59)
at androidx.test.espresso.ViewInteraction.waitForAndHandleInteractionResults(ViewInteraction.java:324)
at androidx.test.espresso.ViewInteraction.check(ViewInteraction.java:306)
at org.mozilla.fenix.ui.robots.BrowserRobot.verifyUrl(BrowserRobot.kt:48)
at org.mozilla.fenix.ui.ContextMenusTest$verifyContextCopyLink$4.invoke(ContextMenusTest.kt:116)
at org.mozilla.fenix.ui.ContextMenusTest$verifyContextCopyLink$4.invoke(ContextMenusTest.kt:35)
at org.mozilla.fenix.ui.robots.NavigationToolbarRobot$Transition.visitLinkFromClipboard(NavigationToolbarRobot.kt:74)
at org.mozilla.fenix.ui.ContextMenusTest.verifyContextCopyLink(ContextMenusTest.kt:115)
at java.lang.reflect.Method.invoke(Native Method)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at androidx.test.internal.runner.junit4.statement.RunBefores.evaluate(RunBefores.java:80)
at androidx.test.internal.runner.junit4.statement.RunAfters.evaluate(RunAfters.java:61)
at androidx.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:531)
at org.junit.rules.RunRules.evaluate(RunRules.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:392)
at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1932)
Caused by: junit.framework.AssertionFailedError: 'with text: a string containing "http://localhost:60312/pages/generic3.html"' doesn't match the selected view.
Expected: with text: a string containing "http://localhost:60312/pages/generic3.html"
Got: "TextView{id=2131296902, res-name=mozac_browser_toolbar_url_view, visibility=VISIBLE, width=834, height=140, has-focus=false, has-focusable=true, has-window-focus=true, is-clickable=true, is-enabled=true, is-focused=false, is-focusable=true, is-layout-requested=false, is-selected=false, layout-params=android.widget.LinearLayout$LayoutParams@5c9320e, tag=null, root-is-layout-requested=false, has-input-connection=false, x=0.0, y=0.0, text=http://localhost:60312/pages/generic4.html, hint=Search or enter address, input-type=0, ime-target=false, has-links=false}"

at androidx.test.espresso.matcher.ViewMatchers.assertThat(ViewMatchers.java:540)
at androidx.test.espresso.assertion.ViewAssertions$MatchesViewAssertion.check(ViewAssertions.java:105)
at androidx.test.espresso.ViewInteraction$SingleExecutionViewAssertion.check(ViewInteraction.java:425)
at androidx.test.espresso.ViewInteraction$2.call(ViewInteraction.java:288)
at androidx.test.espresso.ViewInteraction$2.call(ViewInteraction.java:272)
at java.util.concurrent.FutureTask.run(FutureTask.java:237)
at android.os.Handler.handleCallback(Handler.java:751)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:154)
at android.app.ActivityThread.main(ActivityThread.java:6119)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:886)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:776)

@Pike Pike changed the title Import strings from android-l10n. Import strings from android-l10n Jan 20, 2020
@liuche liuche merged commit 5a429b9 into mozilla-mobile:master Jan 20, 2020
@liuche liuche mentioned this pull request Jan 22, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants