Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

馃幉For #8212 - Fixes shadow/border when toolbar is on top #8234

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

boek
Copy link
Contributor

@boek boek commented Feb 7, 2020

image

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Feb 7, 2020

Codecov Report

Merging #8234 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8234      +/-   ##
============================================
- Coverage     18.67%   18.66%   -0.02%     
  Complexity      452      452              
============================================
  Files           316      316              
  Lines         12331    12339       +8     
  Branches       1619     1619              
============================================
  Hits           2303     2303              
- Misses         9829     9837       +8     
  Partials        199      199
Impacted Files Coverage 螖 Complexity 螖
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (酶) 0 <0> (酶) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1209146...8612cef. Read the comment docs.

@darkwing darkwing changed the title For #8212 - Fixes shadow/border when toolbar is on top 馃幉For #8212 - Fixes shadow/border when toolbar is on top Feb 10, 2020
@darkwing darkwing self-requested a review February 10, 2020 17:07
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great for both top and bottom, and positions switch when changing settings! R+

@darkwing darkwing merged commit f9b05e7 into mozilla-mobile:master Feb 10, 2020
@boek boek deleted the i8212 branch February 10, 2020 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants