UI tests for Private browsing settings sub-menu #8395

sv-ohorvath · 2020-02-13T15:57:12Z

Pull Request checklist

Tests: This PR includes thorough tests or an explanation of why it does not
Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

click on Show All Checks,
click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
click on the "Fenix - assemble" task, then click "Run Artifacts".
the APK links should be on the left side of the screen, named for each CPU architecture

firefoxci-taskcluster · 2020-02-13T15:57:31Z

No Taskcluster jobs started for this pull request

The `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request.

sv-ohorvath · 2020-02-13T15:57:51Z

Currently blocked by:
#8354

codecov-io · 2020-02-14T09:00:53Z

Codecov Report

Merging #8395 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8395      +/-   ##
============================================
+ Coverage     18.89%   18.94%   +0.05%     
+ Complexity      502      500       -2     
============================================
  Files           330      330              
  Lines         13042    13043       +1     
  Branches       1725     1725              
============================================
+ Hits           2464     2471       +7     
+ Misses        10368    10362       -6     
  Partials        210      210

Impacted Files	Coverage Δ	Complexity Δ
...e/intent/FennecBookmarkShortcutsIntentProcessor.kt	`83.33% <0%> (-8.34%)`	`3% <0%> (-2%)`
...la/fenix/components/metrics/GleanMetricsService.kt	`7.78% <0%> (-0.03%)`	`3% <0%> (ø)`
...nix/components/toolbar/BrowserToolbarController.kt	`64.53% <0%> (+2.32%)`	`0% <0%> (ø)`	⬇️
.../settings/quicksettings/QuickSettingsController.kt	`75.47% <0%> (+5.66%)`	`0% <0%> (ø)`	⬇️
...c/main/java/org/mozilla/fenix/components/Search.kt	`100% <0%> (+8.33%)`	`2% <0%> (ø)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec98fd9...4e2e37e. Read the comment docs.

AaronMT · 2020-02-27T20:28:59Z

@sv-ohorvath Is this ready for review now?

sv-ohorvath · 2020-02-28T08:41:31Z

@sv-ohorvath Is this ready for review now?

@AaronMT
Yes, I think it is, I was waiting to run it a few times before asking a review. It passed the last 2 days, so please have a look, especially if I should add anything else to prevent them from flakiness.

AaronMT

There's a lot going on in these tests. I'm concerned for how these work on AVDs and physical devices as there are API differences, and going to the home screen and back. I would rebase and get a run on Firebase and see how it performs a couple times.

app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt

app/src/androidTest/java/org/mozilla/fenix/ui/robots/AddToHomeScreenRobot.kt

app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuPrivateBrowsingRobot.kt

sv-ohorvath · 2020-03-02T14:20:52Z

There's a lot going on in these tests. I'm concerned for how these work on AVDs and physical devices as there are API differences, and going to the home screen and back. I would rebase and get a run on Firebase and see how it performs a couple times.

@AaronMT I've addressed your comments and made some small changes. Please have another look if you can. I'll leave this open another 1-2 days and re-run the tests a few times then see what happens. Thank you!

AaronMT · 2020-03-03T16:13:56Z

There's a lot going on in these tests. I'm concerned for how these work on AVDs and physical devices as there are API differences, and going to the home screen and back. I would rebase and get a run on Firebase and see how it performs a couple times.

@AaronMT I've addressed your comments and made some small changes. Please have another look if you can. I'll leave this open another 1-2 days and re-run the tests a few times then see what happens. Thank you!

Sound's good. I'd rebase as master was broken from an AC change.

Changes and re-review done.

AaronMT · 2020-03-04T15:59:27Z

Let's see how it runs after another rebase once the build is green again.

sv-ohorvath · 2020-03-05T10:25:40Z

PR approved, ran the checks about 10 times and the tests didn't fail so I'm going to merge this.

sv-ohorvath self-assigned this Feb 13, 2020

sv-ohorvath added the eng:automation Build automation, Continuous integration, .. label Feb 13, 2020

sv-ohorvath changed the title ~~UI tests for Private browsing settings sub-menu~~ [Blocked by #8354] UI tests for Private browsing settings sub-menu Feb 13, 2020

sv-ohorvath changed the title ~~[Blocked by #8354] UI tests for Private browsing settings sub-menu~~ [Blocked by #8354] UI tests for Private browsing settings sub-menu Feb 13, 2020

sv-ohorvath force-pushed the openLinksInPrivateMode branch from daf1e93 to f95e0b1 Compare February 14, 2020 08:48

sv-ohorvath force-pushed the openLinksInPrivateMode branch 3 times, most recently from 4383ea9 to bfb233a Compare February 18, 2020 16:38

sv-ohorvath force-pushed the openLinksInPrivateMode branch 3 times, most recently from 88eac35 to fe39845 Compare February 26, 2020 15:29

sv-ohorvath changed the title ~~[Blocked by #8354] UI tests for Private browsing settings sub-menu~~ UI tests for Private browsing settings sub-menu Feb 27, 2020

sv-ohorvath force-pushed the openLinksInPrivateMode branch from fe39845 to a4fec58 Compare February 27, 2020 09:02

sv-ohorvath changed the title ~~UI tests for Private browsing settings sub-menu~~ UI tests for Private browsing settings sub-menu Feb 27, 2020

sv-ohorvath requested review from AaronMT and KMaragh February 28, 2020 08:41

sv-ohorvath force-pushed the openLinksInPrivateMode branch from a4fec58 to b871ac2 Compare February 28, 2020 09:01

AaronMT previously requested changes Feb 28, 2020

View reviewed changes

AaronMT removed the request for review from KMaragh February 28, 2020 16:59

sv-ohorvath force-pushed the openLinksInPrivateMode branch 2 times, most recently from 11e1af3 to 760b0d9 Compare March 3, 2020 08:15

sv-ohorvath changed the title ~~UI tests for Private browsing settings sub-menu~~ UI tests for Private browsing settings sub-menu Mar 3, 2020

sv-ohorvath force-pushed the openLinksInPrivateMode branch from 760b0d9 to 548b205 Compare March 4, 2020 08:52

sv-ohorvath force-pushed the openLinksInPrivateMode branch from 548b205 to fdb51bf Compare March 4, 2020 09:07

sv-ohorvath requested a review from AaronMT March 4, 2020 09:49

sv-ohorvath changed the title ~~UI tests for Private browsing settings sub-menu~~ UI tests for Private browsing settings sub-menu Mar 4, 2020

AaronMT approved these changes Mar 4, 2020

View reviewed changes

UI tests for Private browsing settings sub-menu

4e2e37e

sv-ohorvath force-pushed the openLinksInPrivateMode branch from fdb51bf to 4e2e37e Compare March 5, 2020 08:09

sv-ohorvath changed the title ~~UI tests for Private browsing settings sub-menu~~ UI tests for Private browsing settings sub-menu Mar 5, 2020

sv-ohorvath merged commit 0cdb068 into master Mar 5, 2020

sv-ohorvath deleted the openLinksInPrivateMode branch March 5, 2020 12:33

gmierz pushed a commit to gmierz/fenix that referenced this pull request Mar 5, 2020

UI tests for Private browsing settings sub-menu (mozilla-mobile#8395)

9c38560

liuche mentioned this pull request Mar 12, 2020

Releng 4.1 #9116

Closed

32 tasks

severinrudie pushed a commit to severinrudie/fenix that referenced this pull request Mar 18, 2020

UI tests for Private browsing settings sub-menu (mozilla-mobile#8395)

0a3d843

liuche mentioned this pull request Mar 24, 2020

Releng for 4.2 #9343

Closed

32 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UI tests for Private browsing settings sub-menu #8395

UI tests for Private browsing settings sub-menu #8395

sv-ohorvath commented Feb 13, 2020

firefoxci-taskcluster bot commented Feb 13, 2020

sv-ohorvath commented Feb 13, 2020

codecov-io commented Feb 14, 2020 •

edited

Loading

AaronMT commented Feb 27, 2020

sv-ohorvath commented Feb 28, 2020 •

edited

Loading

AaronMT left a comment

sv-ohorvath commented Mar 2, 2020 •

edited

Loading

AaronMT commented Mar 3, 2020

AaronMT commented Mar 4, 2020

sv-ohorvath commented Mar 5, 2020

UI tests for Private browsing settings sub-menu #8395

UI tests for Private browsing settings sub-menu #8395

Conversation

sv-ohorvath commented Feb 13, 2020

Pull Request checklist

After merge

To download an APK when reviewing a PR:

firefoxci-taskcluster bot commented Feb 13, 2020

sv-ohorvath commented Feb 13, 2020

codecov-io commented Feb 14, 2020 • edited Loading

Codecov Report

AaronMT commented Feb 27, 2020

sv-ohorvath commented Feb 28, 2020 • edited Loading

AaronMT left a comment

Choose a reason for hiding this comment

sv-ohorvath commented Mar 2, 2020 • edited Loading

AaronMT commented Mar 3, 2020

AaronMT commented Mar 4, 2020

sv-ohorvath commented Mar 5, 2020

codecov-io commented Feb 14, 2020 •

edited

Loading

sv-ohorvath commented Feb 28, 2020 •

edited

Loading

sv-ohorvath commented Mar 2, 2020 •

edited

Loading