-
Notifications
You must be signed in to change notification settings - Fork 1.3k
UI tests for Private browsing settings sub-menu #8395
Conversation
No Taskcluster jobs started for this pull requestThe `allowPullRequests` configuration for this repository (in `.taskcluster.yml` on the
default branch) does not allow starting tasks for this pull request. |
Currently blocked by: |
daf1e93
to
f95e0b1
Compare
Codecov Report
@@ Coverage Diff @@
## master #8395 +/- ##
============================================
+ Coverage 18.89% 18.94% +0.05%
+ Complexity 502 500 -2
============================================
Files 330 330
Lines 13042 13043 +1
Branches 1725 1725
============================================
+ Hits 2464 2471 +7
+ Misses 10368 10362 -6
Partials 210 210
Continue to review full report at Codecov.
|
4383ea9
to
bfb233a
Compare
88eac35
to
fe39845
Compare
fe39845
to
a4fec58
Compare
@sv-ohorvath Is this ready for review now? |
@AaronMT |
a4fec58
to
b871ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot going on in these tests. I'm concerned for how these work on AVDs and physical devices as there are API differences, and going to the home screen and back. I would rebase and get a run on Firebase and see how it performs a couple times.
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/SettingsPrivacyTest.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/AddToHomeScreenRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/AddToHomeScreenRobot.kt
Outdated
Show resolved
Hide resolved
app/src/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuPrivateBrowsingRobot.kt
Show resolved
Hide resolved
@AaronMT I've addressed your comments and made some small changes. Please have another look if you can. I'll leave this open another 1-2 days and re-run the tests a few times then see what happens. Thank you! |
11e1af3
to
760b0d9
Compare
Sound's good. I'd rebase as master was broken from an AC change. |
760b0d9
to
548b205
Compare
548b205
to
fdb51bf
Compare
Let's see how it runs after another rebase once the build is green again. |
fdb51bf
to
4e2e37e
Compare
PR approved, ran the checks about 10 times and the tests didn't fail so I'm going to merge this. |
Pull Request checklist
After merge
To download an APK when reviewing a PR: