For #8565: Fix updating dropdown preferences in ETP settings!

[mcarare]

Pull Request checklist

• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[ekager]

nit - license

[ekager]

So why when we get the EntriesValue do we have to find the index of value of this valueString and then return the entry based on the index? What is the newValueString then?

[mcarare]

We have two arrays that store entries and entries values. Previously we received social for example, but we needed Cross-site and social media trackers, otherwise the preference would not have updated.

[codecov-io]

Codecov Report

Merging #8573 into master will increase coverage by 0.04%.
The diff coverage is 21.42%.

@@             Coverage Diff              @@
##             master    #8573      +/-   ##
============================================
+ Coverage     18.62%   18.66%   +0.04%     
  Complexity      464      464              
============================================
  Files           319      320       +1     
  Lines         12737    12747      +10     
  Branches       1682     1683       +1     
============================================
+ Hits           2372     2379       +7     
- Misses        10163    10165       +2     
- Partials        202      203       +1

Impacted Files	Coverage Δ	Complexity Δ
...zilla/fenix/settings/TrackingProtectionFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...la/fenix/settings/StringSharedPreferenceUpdater.kt	0% <0%> (ø)	0 <0> (?)
...g/mozilla/fenix/settings/DropDownListPreference.kt	42.85% <100%> (+42.85%)	0 <0> (ø)	⬇️
...nix/components/toolbar/BrowserToolbarController.kt	60.22% <0%> (+2.27%)	0% <0%> (ø)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd3d29...6bf02b9. Read the comment docs.

[sblatz]

This looks good 😄