This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
Closes #832: Adds custom tabs menu #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
boek
added
the
🙅 waiting
pocmo
reviewed
Mar 11, 2019
| intent.action = Intent.ACTION_VIEW | ||
| intent.data = Uri.parse(session?.url) | ||
| startActivity(intent) | ||
| } |
There was a problem hiding this comment.
We can file a follow-up: In theory you can re-use the same Session. This will avoid reloading the page and the tab will keep all its history and so on. All you need to do is to clear the CustomTabConfig and then select the Session in the SessionManager.
There was a problem hiding this comment.
I tried implementing this, but am getting a displayAlreadyAcquired crash when doing so. I believe we need to fix this bug before we can implement this
There was a problem hiding this comment.
Follow up issue here: #966
sblatz
removed
the
🙅 waiting
boek
approved these changes
Mar 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently blocked on merging until my a-c patch lands