Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Bug 1628413 - Disable Nightlies until Google Play catches up #9810

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

JohanLorenzo
Copy link
Contributor

To see if it matches Google Play's new review delay

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@JohanLorenzo JohanLorenzo requested a review from st3fan April 8, 2020 16:16
@JohanLorenzo JohanLorenzo changed the title Reduce nightly frequency to once a day Disable Nightlies until Google Play catches up Apr 8, 2020
@JohanLorenzo JohanLorenzo changed the title Disable Nightlies until Google Play catches up Bug 1628413 - Disable Nightlies until Google Play catches up Apr 8, 2020
@codecov-io
Copy link

codecov-io commented Apr 8, 2020

Codecov Report

Merging #9810 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #9810   +/-   ##
=========================================
  Coverage     19.19%   19.20%           
  Complexity      521      521           
=========================================
  Files           337      337           
  Lines         13684    13684           
  Branches       1833     1833           
=========================================
+ Hits           2627     2628    +1     
  Misses        10817    10817           
+ Partials        240      239    -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/java/org/mozilla/fenix/components/Search.kt 100.00% <0.00%> (+8.33%) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d93c2...2da0a08. Read the comment docs.

@JohanLorenzo JohanLorenzo merged commit 23e0f9a into mozilla-mobile:master Apr 8, 2020
@JohanLorenzo JohanLorenzo deleted the reduce-nightly branch April 8, 2020 17:04
@liuche liuche mentioned this pull request Apr 13, 2020
32 tasks
@liuche liuche mentioned this pull request Apr 28, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants