Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #9892: Set dynamicToolbarMaxHeigtht to 0 for PWAs #9893

Merged
merged 1 commit into from
Apr 13, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import android.content.Context
import android.view.View
import androidx.navigation.fragment.navArgs
import kotlinx.android.synthetic.main.component_browser_top_toolbar.*
import kotlinx.android.synthetic.main.fragment_browser.*
import kotlinx.android.synthetic.main.fragment_browser.view.*
import kotlinx.coroutines.ExperimentalCoroutinesApi
import mozilla.components.browser.session.Session
Expand Down Expand Up @@ -105,6 +106,7 @@ class ExternalAppBrowserFragment : BaseBrowserFragment(), UserInteractionHandler
customTabSessionId,
trustedScopes
) { toolbarVisible ->
if (!toolbarVisible) { engineView.setDynamicToolbarMaxHeight(0) }
if (!FeatureFlags.dynamicBottomToolbar) { updateLayoutMargins(inFullScreen = !toolbarVisible) }
},
owner = this,
Expand Down
19 changes: 19 additions & 0 deletions docs/metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ This means you might have to go searching through the dependency tree to get a f
This ping is intended to provide a measure of the activation of mobile products. It's generated when Fenix starts, right after Glean is initialized. It doesn't include the client_id, since it might be reporting an hashed version of the Google Advertising ID.


**Data reviews for this ping:**

- <https://github.com/mozilla-mobile/fenix/pull/1707#issuecomment-486972209>

**Bugs related to this ping:**

- 1538011
- 1501822

The following metrics are added to the ping:

| Name | Type | Description | Data reviews | Extras | Expiration |
Expand Down Expand Up @@ -185,6 +194,16 @@ The following metrics are added to the ping:
This ping is intended to capture the source of the installation


This ping includes the [client id](https://mozilla.github.io/glean/book/user/pings/index.html#the-client_info-section).

**Data reviews for this ping:**

- <https://github.com/mozilla-mobile/fenix/pull/8074#issuecomment-586512202>

**Bugs related to this ping:**

- <https://github.com/mozilla-mobile/fenix/issues/7295>

The following metrics are added to the ping:

| Name | Type | Description | Data reviews | Extras | Expiration |
Expand Down