This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #10148 - Add basic tab tray implementation without exposing to rest of app #9934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkwing
added
the
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
label
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #9934 +/- ##
============================================
- Coverage 18.97% 18.86% -0.12%
Complexity 532 532
============================================
Files 343 344 +1
Lines 13944 14039 +95
Branches 1869 1882 +13
============================================
+ Hits 2646 2648 +2
- Misses 11057 11150 +93
Partials 241 241
Continue to review full report at Codecov.
|
darkwing
force-pushed
the
new-tab-tray
branch
4 times, most recently
from
April 20, 2020 18:46
1136eb4
to
f3d5796
Compare
darkwing
changed the title
WIP: New tab tray
Add basic tab tray implementation without exposing to rest of app
Apr 20, 2020
darkwing
force-pushed
the
new-tab-tray
branch
4 times, most recently
from
April 21, 2020 19:19
15e5ca4
to
011d0d3
Compare
darkwing
removed
the
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
label
Apr 22, 2020
ekager
reviewed
Apr 22, 2020
ekager
reviewed
Apr 22, 2020
ekager
reviewed
Apr 22, 2020
app:layout_constraintStart_toStartOf="parent" | ||
app:layout_constraintBottom_toTopOf="@id/tab_tray_controls" /> | ||
|
||
<LinearLayout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we using a linear layout for these buttons? Probably better to do a nested constraint in terms of performance?
darkwing
changed the title
Add basic tab tray implementation without exposing to rest of app
For #10148 - Add basic tab tray implementation without exposing to rest of app
Apr 23, 2020
ekager
reviewed
Apr 23, 2020
ekager
reviewed
Apr 23, 2020
ekager
reviewed
Apr 23, 2020
ekager
reviewed
Apr 23, 2020
ekager
reviewed
Apr 23, 2020
ekager
approved these changes
Apr 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ with some nits
boek
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10148
Current view:
Pull Request checklist
After merge
To download an APK when reviewing a PR: