-
Notifications
You must be signed in to change notification settings - Fork 320
Bug 1807131: Fix ripples for snackbar and alert dialogs #1226
Conversation
🚧 Commit message is using the wrong format: Add ripple XML The comment message should look like:
|
@csadilek would like to ask you on this. What do you think of this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job!
Thanks for the patch!
817513f
to
7eead68
Compare
<!-- This Source Code Form is subject to the terms of the Mozilla Public | ||
- License, v. 2.0. If a copy of the MPL was not distributed with this | ||
- file, You can obtain one at http://mozilla.org/MPL/2.0/. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czlucius I added the licenses to each files, also squashed the commits into a single one.
Thanks |
@delia-pop I tested it on the update today (from the Play Store), and it seems to work on light mode as well. Can you confirm this behaviour? However, I'd like to file a new issue as the ripple seems to be off-centre, which did not happen when I was testing this change on my device before the patch was merged. I can't post on Bugzilla since the issue is closed |
@delia-pop The above image is for |
Hi, @czlucius , thanks for reaching out!
DialogueButtonAnimation.mp4Since this seems a device issue, please let me know if you think we should file a ticket for this behavior anyway. Regarding the issue you mentioned, with the ripple animation not centered on the "OK" button on alerts, I can also reproduce it and I will shortly open a ticket for it. Here's the ticket: https://bugzilla.mozilla.org/show_bug.cgi?id=1833661 |
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1807131