Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1807268 - Disable toggleSearchBookmarksAndHistoryTest UI test #1234

Merged
merged 4 commits into from Mar 14, 2023
Merged

Bug 1807268 - Disable toggleSearchBookmarksAndHistoryTest UI test #1234

merged 4 commits into from Mar 14, 2023

Conversation

AndiAJ
Copy link
Contributor

@AndiAJ AndiAJ commented Mar 14, 2023 •
edited by github-actions bot

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Breaking Changes: If this is a breaking Android Components change, please push a draft PR on Reference Browser to address the breaking issues.

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-apk-{fenix,focus,klar}-debug task you're interested in.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

https://bugzilla.mozilla.org/show_bug.cgi?id=1807268

@AndiAJ AndiAJ self-assigned this Mar 14, 2023
@AndiAJ AndiAJ added the 🕵️‍♀️ needs review PRs that need to be reviewed label Mar 14, 2023
@AndiAJ AndiAJ added 🛬 needs landing PRs that are ready to land and removed 🕵️‍♀️ needs review PRs that need to be reviewed 🛬 needs landing PRs that are ready to land labels Mar 14, 2023
@AndiAJ AndiAJ force-pushed the toggleSearchBookmarksAndHistoryTest branch from 05a7a17 to 274754e Compare March 14, 2023 15:13
@AndiAJ AndiAJ added the 🛬 needs landing PRs that are ready to land label Mar 14, 2023
@JohanLorenzo JohanLorenzo mentioned this pull request Mar 14, 2023
Open
@mergify mergify bot merged commit 9e47d73 into mozilla-mobile:main Mar 14, 2023
@AndiAJ AndiAJ deleted the toggleSearchBookmarksAndHistoryTest branch March 15, 2023 07:30
jcristau added a commit to jcristau/firefox-android that referenced this pull request May 29, 2023
@jcristau
Bug 1822349 - monorepo-migration: avoid some overeager replacements
9cf0f84 
Ensure the `#NNNN` comes after a non-alphanumeric character so we don't turn
e.g. `foo#1234` into
`foohttps://github.com/mozilla-mobile/pull/1234`
mergify bot pushed a commit that referenced this pull request May 30, 2023
@jcristau @mergify
Bug 1822349 - monorepo-migration: avoid some overeager replacements
32c7213 
Ensure the `#NNNN` comes after a non-alphanumeric character so we don't turn
e.g. `foo#1234` into
`foohttps://github.com//pull/1234`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronMT AaronMT AaronMT approved these changes

@sv-ohorvath sv-ohorvath Awaiting requested review from sv-ohorvath

Assignees

@AndiAJ AndiAJ

Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndiAJ @AaronMT @rvandermeulen