Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1800542 - Bug fix for part 4 #177

Merged
merged 1 commit into from Nov 17, 2022
Merged

Bug 1800542 - Bug fix for part 4 #177

merged 1 commit into from Nov 17, 2022

Conversation

gbrownmozilla
Copy link
Collaborator

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

GitHub Automation

Used by GitHub Actions.

@gbrownmozilla
Copy link
Collaborator Author

This is to fix the problem seen in https://firefoxci.taskcluster-artifacts.net/UES29ipWRQOZ1BM5LiAbDQ/0/public/logs/live_backing.log:

[task 2022-11-17T18:38:12.277Z]   File "/builds/worker/checkouts/vcs/taskcluster/ac_taskgraph/loader/build_config.py", line 128, in loader
[task 2022-11-17T18:38:12.277Z]     if "dependencies-src" in affected_components:
[task 2022-11-17T18:38:12.277Z] TypeError: argument of type 'object' is not iterable

If the get_affected_components() branch hasn't been run, then affected_components is already ALL_COMPONENTS (which would complicate the check for dependencies-src).

@gbrownmozilla gbrownmozilla requested review from a team and hneiva and removed request for a team November 17, 2022 20:04
Copy link

@hneiva hneiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp'd

@rvandermeulen rvandermeulen added the 🛬 needs landing PRs that are ready to land label Nov 17, 2022
@mergify mergify bot merged commit e3f00d3 into main Nov 17, 2022
@bors bors bot deleted the bug1800542 branch November 17, 2022 20:34
Copy link
Collaborator

@JohanLorenzo JohanLorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you guys for this hotfix! I'm sorry I missed that in the fix I provided. I'm glad the decision task is back to green on the main branch!

Follows up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛬 needs landing PRs that are ready to land
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants