This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Bug 1800542 - part 6: Support multiple locations of Gecko.kt dependin… #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g on the git history
jcristau
approved these changes
Nov 18, 2022
| gecko_kt = repo.run( | ||
| "show", f"{revision}:android-components/plugins/dependencies/src/main/java/Gecko.kt" | ||
| "show", f"{revision}:{gecko_kt_path}" |
There was a problem hiding this comment.
Couldn't we just try git show on the new path and fall back to the old path if that doesn't work? Then we don't have to care about the exact moved revision.
There was a problem hiding this comment.
We could, although any error raised by git will be caught under the generic CalledProcessError. So we would try to fallback to the old path even though the first command failed for an unrelated reason.
In the current implementation, we're safer because git merge-base --is-ancestor fails by design.
There was a problem hiding this comment.
I'm happy to make any follow-up changes, if you wish 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g on the git history
While working on bug 1799668, I realized our parameter files in
taskcluster/test/params/are now all busted because they all predate #148. I could have updated them but I think we should just support both Gecko.kt locations. This way, taskgraph works no matter the revision.Follows up:
head_refto rebuild all comp… #173