New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1841262 — Add coenrolling features to NimbusBuilder #2682
Bug 1841262 — Add coenrolling features to NimbusBuilder #2682
Conversation
I'm hitting significant issues trying to test this and having to reset a lot of my dev box (larger issues than this PR). Not sure if someone else can pick this up to review but if it's passing the builds tomorrow I'll focus on reviewing the code and approve. |
5a4a644
to
306ef3f
Compare
This commit refactors the android-components implementations of `NimbusBuilder` and `Nimbus` to accommodate the new `getCoenrollingFeatureIds()` API. This API is internal to Application Services, but needs to be passed in via the constructor of the Nimbus object.
306ef3f
to
7205824
Compare
🚧 Commit message is using the wrong format: Update A-S to 117.20230706050813. The comment message should look like:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…-to-nimbus-builder
🚧 Commit message is using the wrong format: Update A-S to 117.20230706050813. The comment message should look like:
|
Relates to EXP-3623.
Fixes Bug 1841262.
This commit refactors the android-components implementations of
NimbusBuilder
andNimbus
to accommodate the newgetCoenrollingFeatureIds()
API.This API is internal to Application Services, but needs to be passed in via the constructor of the Nimbus object.
This will not build correctly until mozilla/application-services#5697 lands and reaches this repo.
Because this is a breaking change, we've taken the opportunity to do several things here:
onFetchCallback
andonApplyCallback
into ASgetEnrollingFeatureIds()
come from theNimbusBuilder
Nimbus
object to theNimbusBuilder
.Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1841262