New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1810047 - Implement UI for webextensions optional permissions. #3917
Conversation
4e653d2
to
8b6440a
Compare
8b6440a
to
943e6ac
Compare
fenix/app/src/main/java/org/mozilla/fenix/extension/WebExtensionPromptFeature.kt
Show resolved
Hide resolved
fenix/app/src/main/java/org/mozilla/fenix/extension/WebExtensionPromptFeature.kt
Show resolved
Hide resolved
fenix/app/src/test/java/org/mozilla/fenix/extension/WebExtensionPromptFeatureTest.kt
Show resolved
Hide resolved
...ts/browser/engine-gecko/src/main/java/mozilla/components/browser/engine/gecko/GeckoEngine.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As chatted via Slack, we will further investigate if we should auto grant directly on gecko/geckoview. At the moment, we are duplicating this functionality in Desktop and Fenix, eventually we will get Gecko on iOS. This seams to be a core functionality that shouldn't left to handle to consumers.
Thanks for fixing my extension, but be aware that the permissions granted via this dialog are not visible (and thus cannot be revoked) from the extension's Permissions UI. |
the extension can revoke them |
@pmarks-net sorry for the quick reply the other day, to expand on that: yes, you're right. We don't have UI for optional permissions in the Fenix details view. There is a bug for that, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1811563. We'll get that fixed eventually but I don't have an ETA yet. In the meantime, extensions can offer optional permission removal using |
Pull Request checklist
After merge
To download an APK when reviewing a PR (after all CI tasks finished running):
Checks
at the top of the PR page.firefoxci-taskcluster
group on the left to expand all tasks.build-apk-{fenix,focus,klar}-debug
task you're interested in.View task in Taskcluster
in the newDETAILS
section.GitHub Automation
https://bugzilla.mozilla.org/show_bug.cgi?id=1810047