Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private tabs are lost after force close - "close private tabs" button missing from settings #20073

Open
DianaABarladeanu opened this issue Apr 30, 2024 · 23 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected

Comments

@DianaABarladeanu
Copy link

DianaABarladeanu commented Apr 30, 2024

Steps to reproduce

  1. Fresh install FF.
  2. Go to private browsing and open some tabs.
  3. Force close the app.
  4. Reopen the app and observe tabs tray.

Expected behavior
Alll tabs (normal and private) are restored.

Actual behavior
Private tabs are closed.
"Close private tabs" button is missing from settings.

Device & build information

  • Device: iPhone 15 (17.4)
  • Build version:v9000 (41381)
  • First seen version: ?

Notes
This issue only reproduces on the v9000 build.

Attachments:

RPReplay_Final1714474538.mp4

┆Issue is synchronized with this Jira Task

@DianaABarladeanu DianaABarladeanu added the Bug 🐞 This is a bug with existing functionality not behaving as expected label Apr 30, 2024
@data-sync-user
Copy link
Collaborator

➤ Norberto Andres Furlan commented:

Diana Andreea Barladeanu this is expected behavior.

@zach-flaglerhealth
Copy link

Since when is this expected behavior? I only ever use Private Tabs and Firefox iOS has persisted those (for 3+ years). Issue #15989 seems to be where the discussion of this bug is otherwise taking place, but was there a behavior change that was intended and not communicated?

@SomewhatOrangish
Copy link

Since when is this expected behavior? I only ever use Private Tabs and Firefox iOS has persisted those (for 3+ years). Issue #15989 seems to be where the discussion of this bug is otherwise taking place, but was there a behavior change that was intended and not communicated?

Like Zach, this took me completely by surprise and I"m quite frustrated by it.

@rschristian
Copy link

Indeed, as a heavy user over the past few years, private tab persistence has been a (largely) reliable feature and it matches other browsers on the platform. Safari doesn't drop private tabs, why should FireFox?

In fact, if you take a look through Reddit, you'll find instances of Mozilla employees apologizing over particularly buggy updates that broke private tab persistence and dropped tabs.

If this is intended to be a new change, it should've been announced well ahead of time and needs justification for divergence from a) existing expectations/behavior and b) from other apps on the platform.

@Woozlebats
Copy link

I’m in the same boat, I lost so much shit that was really important to me. I won’t pretend it was the greatest system for maintaining all the things I wanted to come back to but I never had any issues until for some reason they decided we don’t get that feature anymore. Really sucks

@venezia
Copy link

venezia commented Jun 17, 2024

I would consider this a feature change - and one I'm not in favor of. I don't see it being mentioned in the release notes and if it had been mentioned, I wouldn't have upgraded.

It's a real bummer and now I'm unsure if I should continue with this app - it was a feature I relied on.

@likeasummerain
Copy link

This is absolutely not expected behavior. I have been saving pages to look at later this way for years. I just lost 30 + items on my to do list and I don’t have any idea what they are. I use private browsing for security and because I don’t want to be tracked between sites, and now I’ll have to find a new browser. The lack of tab functionality is exactly why I don’t use the focus browser and now this one is ruined too. If I don’t close the tab I want it to be there when I go back, that’s why it’s open, that’s the whole point.

@aodgizmo
Copy link

Not even having the option which is as simple as a check box in the settings, to keep tabs open if the user wanted to is a huge kick in the nuts to the people that did. Really hate it when "feature" changes are done just to change things that have been like that for years, I am all for bug fixes and the like, but stuff like this is just annoying.

@garnetred
Copy link

I've also noticed this same behavior even if you don't force-close the app - sometimes when you open the app after it's been out of focus for a while, it'll close all the private windows and open a default new tab in the regular section, and other times it won't. The varied behavior makes it hard to keep track of any work in private tabs at all.

@scribblemaniac
Copy link

Like many, I am not happy with this change to say the least. Even if I did agree that private tabs should be deleted when the application is closed (which I don't, on mobile at least), the way this change has been handled is completely unacceptable. Please put someone on the firefox-ios development team that understands that open tabs are valuable personal data to some people. Deleting tabs which have been persistent for years without any warning or any means of exporting/transferring/backing them after upgrading up is not okay. Not even listing changes that would cause them to be deleted in the change log is not okay.

When the testimonials of users started coming it saying they're losing things important to them, a new update reverting this change should have been pushed right away before further damage could be done. Instead a week after the release went live and over a month after this issue was first reported we get absolutely no official response here or on any of the aforementioned threads except to say that this is "expected", and a minor update that makes absolutely no attempt to correct this issue or prevent further tab loss as more users upgrade. All of the shortcomings in the handling of this issue (not to mention the questionable decisions that lead to this change in the first place and previous tab loss issues) have destroyed any confidence I have in Firefox for iOS and have made me reevaluate my support for Mozilla as a whole.


Since Mozilla isn't rushing to rectify this issue, I have taken it upon myself to write a tool that can recovery a list of all tabs (including private ones) under some circumstances. It requires some comfort with the command line+Docker and a full local backup of your device that was taken before running Firefox 127.0 for the first time. Simply restoring the backup does not help because iOS backups don't downgrade apps, so even if you restore your private tab data Firefox will just delete it again the instant you open the app 🤦. This tool extracts the tab URLs directly from the backup data to avoid this problem. I was fortunate enough to have made a backup recently, and hopefully some other people can benefit from this as well. It can be found here: https://github.com/scribblemaniac/firefox-ios-tab-recovery.

@robpneu
Copy link

robpneu commented Jun 22, 2024

Yep, lost about a dozen tabs here. Unfortunately this has pushed me back to using Safari as my default on iOS (which does keep my private tabs open!). I’ll keep Firefox installed purely to for the share sheet to send links to Firefox on my desktop or laptop.

Like many, I am not happy with this change to say the least. Even if I did agree that private tabs should be deleted when the application is closed (which I don't, on mobile at least), the way this change has been handled is completely unacceptable. Please put someone on the firefox-ios development team that understands that open tabs are valuable personal data to some people. Deleting tabs which have been persistent for years without any warning or any means of exporting/transferring/backing them after upgrading up is not okay. Not even listing changes that would cause them to be deleted in the change log is not okay.

I mostly agree. They really messed up here. Unfortunately just adding it to the changes would not have helped me as I allow iOS to keep all my apps up to date and I very rarely actually check the change notes as most developers don’t even put an actual list. At a glance I’d say at least half of Firefox’s “Bug Fixes”. This change was definitely not listed on the 127.0 update.

Since Mozilla isn't rushing to rectify this issue, I have taken it upon myself to write a tool that can recovery a list of all tabs (including private ones) under some circumstances. It requires some comfort with the command line+Docker and a full local backup of your device that was taken before running Firefox 127.0 for the first time. Simply restoring the backup does not help because iOS backups don't downgrade apps, so even if you restore your private tab data Firefox will just delete it again the instant you open the app 🤦. This tool extracts the tab URLs directly from the backup data to avoid this problem. I was fortunate enough to have made a backup recently, and hopefully some other people can benefit from this as well. It can be found here: https://github.com/scribblemaniac/firefox-ios-tab-recovery.

You’re awesome! I haven’t done a local backup in years so this does nothing for me (I’ve just accepted my tabs are lost) but props to you for coming up with at least some sort of solution that I hope will help someone out there.

@mathmodave
Copy link

It looks like this was discussed in FXIOS-8672, although I don't have access to that JIRA to take a look at the discussion.

Of the three PRs that I see that reference FXIOS-8672, one of them mentions:

I've intentionally kept this PR as simple as possible so we can release it and then be sure there is no major blow back from users. If we need to roll back it should be very simple in the current state.

I'm not sure what would count as "major blow back" but there is at least some hope that this functionality can be restored.

I agree with @garnetred that this behaviour isn't limited to force closing the app.

@mapster127
Copy link

There are many of us wrestling with this unannounced and unwelcome change - see the Mozilla community posts here https://connect.mozilla.org/t5/discussions/private-tabs-ios-no-longer-automatically-stay-open-since-new/m-p/59620#M20963
For example. Yet no clear response from Mozilla anywhere and I doubt many of us suffering even thought about looking here on GitHub. It seems like FIXIOS-8672 may be intended to correct this but what is the timing? Firefox is essentially unusable for me in the interim but both the declaration above that this unannounced change is intentional and the lack of any obvious comment from Mozilla has me wondering whether I should even bother continuing with Firefox. Like others I’m defaulting back to Safari for now. How difficult is it for some public comment, or even acknowledgment of the issue to be made?

@ThinkChaos
Copy link
Contributor

Please at least add an option to turn this off.
IMO this should've at least had a prompt on first post-update launch because, even if I understand the intention, data loss is not cool.

@mapster127
Copy link

And just to reinforce this is not just on crash or force quit. Firefox on iOS for iPad 17.5.1 has done this overnight every night for the last week or more (with the browser open but out of focus). Now today and yesterday it is randomly throwing all private tabs away every couple of hours. Again browser not closed or crashed and iPad not shut down. So just what the heck is going on? Surely this behaviour cannot be intentional?

@robpneu
Copy link

robpneu commented Jun 25, 2024

And just to reinforce this is not just on crash or force quit.

correct, it’s whenever the app is unloaded from RAM. Crashing and force quit both do that. iOS itself also does it automatically when it’s in the background (probably the same as “not in focus” as you put it) and iOS decides it should be unloaded from RAM. That’s what’s happening to you every couple of hours. This happens to all apps on iOS it’s just that most other apps actually try to save the state you left them in and then restore it when it’s opened again so you don’t notice, instead of just throwing away what you left open like Firefox is doing, at least in part.

@mapster127
Copy link

Thanks @robpneu good point. I wasn’t thinking about how iOS was behaving here. But the fact that this is normal behaviour from the OS leaves me baffled that anyone would think not restoring tabs is in any way helpful. There are bound to be times in the day when one’s focus or priorities change, other apps are used, before returning to a prior topic being researched or other use of a Firefox tab. I fail to comprehend a use case/user story that would take precedence and expect those open tabs to be dropped. But I guess whoever decided to push this change also decided those users impacted did not have equally important needs.

@likeasummerain
Copy link

Exactly! And it's even worse because links open in private if that was the last place you were using the app. I keep finding myself having to copy and paste links from private to regular so that they are actually available when I want them.

@ru-mi-al
Copy link

I am currently using Firefox 127.1 (42781).
Since 2 days I lost all my tabs. I simply closed Firefox in the evening and the next day when I opened it, all tabs and private tabs were lost.
I understand this issue was fixed in version 116.2.

116.1 update deleted all open tabs #15989

The bug was reintroduced in version 127.1?
Anyway please let me know if there is a way to restore all my tabs.
Thanks

@ogra01
Copy link

ogra01 commented Jul 1, 2024

Adding my support for this ticket. Private tabs absolutely did not close in the past so this is a feature change or a bug. There is no good reason for private tabs to disappear. Please fix this issue and make them behave like normals tabs again. Thank you

@LDCK
Copy link

LDCK commented Jul 1, 2024

The worst part about this update/bug is that I can no longer click a hyperlink and have it open by default to a private browsing tab.

@mkismy
Copy link

mkismy commented Jul 4, 2024

I guess Mozilla cares no more privacy anymore 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected
Projects
None yet
Development

No branches or pull requests