Bugfix FXIOS-8672 Skip private tab data on store #19936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| privacySettings += [ | ||
| BoolSetting(prefs: profile.prefs, | ||
| theme: themeManager.currentTheme(for: windowUUID), | ||
| prefKey: "settings.closePrivateTabs", |
There was a problem hiding this comment.
@OrlaM I think there are a few other places with related code we can probably clean up
There was a problem hiding this comment.
Sorry I should have left a comment about it, there are a bunch of other places too with code that can be simplified. I've intentionally kept this PR as simple as possible so we can release it and then be sure there is no major blow back from users. If we need to roll back it should be very simple in the current state. I'll create a follow up ticket and assign it myself to get back to this after 127 has been live for a few weeks.
There was a problem hiding this comment.
Ok sounds good. Change LGTM
Client.app: Coverage: 30.94
Generated by 馃毇 Danger Swift against 4963b94 |
mattreaganmozilla
approved these changes
Apr 23, 2024
OrlaM
requested review from
AaronMT and
clarmso
and removed request for
AaronMT
clarmso
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃摐 Tickets
Jira ticket
馃挕 Description
Skip private tab data on store. Private tabs will no longer be restored when restarting Firefox.
Also removed the setting from settings as that is now the default behaviour.
馃摑 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)