Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix FIOS-4 Update shavar to fix x.com #20310

Merged
merged 1 commit into from
May 17, 2024
Merged

Bugfix FIOS-4 Update shavar to fix x.com #20310

merged 1 commit into from
May 17, 2024

Conversation

thatswinnie
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Updates Shavar hash to include x.com for Focus.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@thatswinnie thatswinnie requested a review from a team as a code owner May 17, 2024 13:42
@thatswinnie
Copy link
Contributor Author

@Mergifyio backport release/v127

@thatswinnie
Copy link
Contributor Author

@Mergifyio backport release/v126

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport release/v127

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 17, 2024 •
edited
Loading

backport release/v126

✅ Backports have been created

@thatswinnie thatswinnie merged commit 8a52473 into main May 17, 2024
8 checks passed
@thatswinnie thatswinnie deleted the wt/FIOS-4-Update-shavar-to-fix-x.com branch May 17, 2024 13:57
mergify bot pushed a commit that referenced this pull request May 17, 2024
@thatswinnie @mergify
Bugfix FIOS-4 Update shavar to fix x.com (#20310)
5919b5e 
(cherry picked from commit 8a52473)
mergify bot pushed a commit that referenced this pull request May 17, 2024
@thatswinnie @mergify
Bugfix FIOS-4 Update shavar to fix x.com (#20310)
243ac45 
(cherry picked from commit 8a52473)
This was referenced May 17, 2024
Merged
Merged
thatswinnie added a commit that referenced this pull request May 17, 2024
@mergify @thatswinnie
Bugfix FIOS-4 Update shavar to fix x.com (#20310) (#20311)
5dc708e 
(cherry picked from commit 8a52473)

Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
DonalMe pushed a commit that referenced this pull request May 17, 2024
@mergify @thatswinnie
Bugfix FIOS-4 Update shavar to fix x.com (#20310) (#20312)
7a3ba10 
(cherry picked from commit 8a52473)

Co-authored-by: Winnie Teichmann <4530+thatswinnie@users.noreply.github.com>
mattreaganmozilla pushed a commit to mattreaganmozilla/firefox-ios that referenced this pull request May 18, 2024
@thatswinnie @mattreaganmozilla
Bugfix FIOS-4 Update shavar to fix x.com (mozilla-mobile#20310)
e3bb8ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyndichin cyndichin cyndichin approved these changes

@PARAIPAN9 PARAIPAN9 Awaiting requested review from PARAIPAN9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thatswinnie @cyndichin