Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix FXIOS-9180 - Remove Duplicate Undo Close Tab Toast #20447

Conversation

tisumi99
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Removed store.dispatch(toastAction) from TabManagerMiddleware.tabPeekCloseTab since the toast will be dispatched again from TabDisplayPanel.newState. This keeps the toast from displaying twice.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@tisumi99 tisumi99 requested a review from a team as a code owner May 28, 2024 17:43
@tisumi99
Copy link
Contributor Author

Before (Video at 0.4x Speed)

Untitled-ezgif.com-video-speed.mov

After (Video at 1.0x Speed)

Screen.Recording.2024-05-28.at.10.45.48.AM.mov

@mobiletest-ci-bot
Copy link

Messages
📖 Project coverage: 32.49%
📖 Edited 1 files
📖 Created 0 files

Client.app: Coverage: 31.19

File Coverage
TabManagerMiddleware.swift 8.11% ⚠️

Generated by 🚫 Danger Swift against b12fbb8

@mattreaganmozilla
Copy link
Collaborator

Thanks @tisumi99 for this PR

@mattreaganmozilla mattreaganmozilla changed the title Remove FXIOS-9180 - Remove Duplicate Undo Close Tab Toast Bugfix FXIOS-9180 - Remove Duplicate Undo Close Tab Toast May 28, 2024
@mattreaganmozilla mattreaganmozilla merged commit 2a3c886 into mozilla-mobile:main May 28, 2024
8 of 10 checks passed
@tisumi99 tisumi99 deleted the 20340CloseTabToastShowingMultipleTimes branch May 28, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants