Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tab tray refactor] "Tab closed - Undo" toast message glitch (intermittent) #20340

Closed
DianaABarladeanu opened this issue May 20, 2024 · 3 comments
Closed

[Tab tray refactor] "Tab closed - Undo" toast message glitch (intermittent) #20340

DianaABarladeanu opened this issue May 20, 2024 · 3 comments
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project

Comments

@DianaABarladeanu
Copy link

DianaABarladeanu commented May 20, 2024 •
edited by data-sync-user
Loading

Steps to reproduce

  1. Make sure you have some tabs in tab tray.
  2. Long tap on a tab to open context menu.
  3. Choose to close the tab and observe the toast message.

Expected behavior
"Tab closed - Undo" toast message is displayed once.

Actual behavior
"Tab closed - Undo" toast message seems to be doubled/has a glitch in some cases.

Device & build information

  • Device: iPhone 15 (17.4); iPhone 15+ (17.4)
  • Build version: v127 (42000)
  • First seen version: ?

Notes
Attachments:
https://github.com/mozilla-mobile/firefox-ios/assets/151131988/b6576308-6314-44a5-96c1-59843ce7150a

┆Issue is synchronized with this Jira Task
@DianaABarladeanu DianaABarladeanu added the Bug 🐞 This is a bug with existing functionality not behaving as expected label May 20, 2024
@nbhasin2 nbhasin2 added the Contributor OK This is a good issue for contributors interested in helping the project label May 23, 2024
@tisumi99
Copy link
Contributor

The toast message is indeed being called twice. Most of the time the duplicates appear simulataneously and we don't see the duplicates but every once in a while there is a short delay between the duplicates and we see the glitch. I will submit a PR/fix for this shortly.

@tisumi99 tisumi99 mentioned this issue May 28, 2024
Merged
6 tasks
@data-sync-user data-sync-user added the Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval label May 28, 2024
@data-sync-user
Copy link
Collaborator

➤ Diana Andreea Barladeanu commented:

Verified as fixed on v9000 (42506), with iPhone 15 (17.4.1).

!RPReplay_Final1717585546.mp4|width=590,height=1280,alt="RPReplay_Final1717585546.mp4"!

@data-sync-user
Copy link
Collaborator

➤ Adina Petridean commented:

Verified as fixed on Firefox 128.0 (42711), with iPhone 14 Pro Max (16.2).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug 🐞 This is a bug with existing functionality not behaving as expected Contributor Fix A contributor has fixed this issue. It might still be opened as we're waiting for final QA approval Contributor OK This is a good issue for contributors interested in helping the project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nbhasin2 @data-sync-user @tisumi99 @DianaABarladeanu